Replace Cython with nanobind for Python bindings#272
Draft
pablogsal wants to merge 1 commit intobloomberg:mainfrom
Draft
Replace Cython with nanobind for Python bindings#272pablogsal wants to merge 1 commit intobloomberg:mainfrom
pablogsal wants to merge 1 commit intobloomberg:mainfrom
Conversation
pablogsal
force-pushed
the
redone
branch
6 times, most recently
from
3a5e25c to
9e2a123
Compare
The Cython-based bindings required extensive marshaling between Python and C++ data structures, causing performance overhead and maintenance complexity. Each call crossed the language boundary multiple times, converting maps, thread lists, and frame data back and forth. This migration moves to nanobind with scikit-build-core for the build system. The key architectural change is moving logic that previously lived in Cython or Python into C++: maps parsing, version detection, and thread construction now happen entirely in C++ before returning results to Python. This eliminates round-trips and simplifies the codebase by removing the Cython layer entirely. The Python API remains unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cython-based bindings required extensive marshaling between Python
and C++ data structures, causing performance overhead and maintenance
complexity. Each call crossed the language boundary multiple times,
converting maps, thread lists, and frame data back and forth.
This migration moves to nanobind with scikit-build-core for the build
system. The key architectural change is moving logic that previously
lived in Cython or Python into C++: maps parsing, version detection,
and thread construction now happen entirely in C++ before returning
results to Python. This eliminates round-trips and simplifies the
codebase by removing the Cython layer entirely. The Python API remains
unchanged.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.