Skip to content

Remove stale test skipping - KTLO#278

Merged
pablogsal merged 2 commits intobloomberg:mainfrom
scopreon:remove_pyinstaller_skip
Feb 23, 2026
Merged

Remove stale test skipping - KTLO#278
pablogsal merged 2 commits intobloomberg:mainfrom
scopreon:remove_pyinstaller_skip

Conversation

@scopreon
Copy link
Contributor

I didn't think this needed a dedicated issue. Happy to create one if necessary.

Describe your changes
Remove the stale PyInstaller version checking in test_relocatable_cores.py.. It now also supports 3.13+3.14.

Testing performed
Test coverage implicitly increased by removing code ;)

Additional context
Found when looking through codebase

scopreon and others added 2 commits February 22, 2026 16:26
Remove test skipping in test_relocatable_cores.py.

PyInstaller now additionally supports Python 3.13/3.14.
Copy link
Collaborator

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot @scopreon

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a stale integration-test skip that prevented test_relocatable_cores.py from running on newer Python versions, aligning the test suite with current CI coverage for 3.13/3.14.

Changes:

  • Removed pytest.mark.skipif gating the relocatable core integration test on Python version.
  • Dropped the now-unused import pytest from the integration test module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.03%. Comparing base (d6194db) to head (cc8507a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   83.03%   83.03%   -0.01%     
==========================================
  Files          48       48              
  Lines        6244     6242       -2     
  Branches      480      480              
==========================================
- Hits         5185     5183       -2     
  Misses       1059     1059              
Flag Coverage Δ
cpp 83.03% <ø> (-0.01%) ⬇️
python_and_cython 83.03% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pablogsal pablogsal merged commit 58dcac6 into bloomberg:main Feb 23, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants