Remove stale test skipping - KTLO#278
Merged
pablogsal merged 2 commits intobloomberg:mainfrom Feb 23, 2026
Merged
Conversation
Remove test skipping in test_relocatable_cores.py. PyInstaller now additionally supports Python 3.13/3.14.
There was a problem hiding this comment.
Pull request overview
Removes a stale integration-test skip that prevented test_relocatable_cores.py from running on newer Python versions, aligning the test suite with current CI coverage for 3.13/3.14.
Changes:
- Removed
pytest.mark.skipifgating the relocatable core integration test on Python version. - Dropped the now-unused
import pytestfrom the integration test module.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 83.03% 83.03% -0.01%
==========================================
Files 48 48
Lines 6244 6242 -2
Branches 480 480
==========================================
- Hits 5185 5183 -2
Misses 1059 1059
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't think this needed a dedicated issue. Happy to create one if necessary.
Describe your changes
Remove the stale PyInstaller version checking in
test_relocatable_cores.py.. It now also supports 3.13+3.14.Testing performed
Test coverage implicitly increased by removing code ;)
Additional context
Found when looking through codebase