Skip to content

fix(ci): rebuild from clean in size-report so build-config changes are measured#90

Open
natemoo-re wants to merge 1 commit into
mainfrom
fix/size-report-rebuild
Open

fix(ci): rebuild from clean in size-report so build-config changes are measured#90
natemoo-re wants to merge 1 commit into
mainfrom
fix/size-report-rebuild

Conversation

@natemoo-re

Copy link
Copy Markdown
Member

The size report builds head then base without cleaning in between. For PRs that change only build configuration (Makefile, patches/, compiler flags) and not src/*.c, make sees clayterm.wasm as newer than the unchanged sources and skips the base rebuild — so the base step re-measures the head artifact, the delta comes out 0, and no size comment is posted even though the wasm size actually changed.

…e measured

The size report builds head then base without cleaning between them. For PRs that change only build config (Makefile, patches/, flags) and not src/*.c, make sees clayterm.wasm as newer than the unchanged sources and skips the base rebuild, so base re-measures head's artifact, delta is 0, and no size comment is posted. Run make clean && make for both builds so each is from scratch.
@pkg-pr-new

pkg-pr-new Bot commented Jun 6, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/clayterm@90

commit: 96efff6

@codspeed-hq

codspeed-hq Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 40.53%

❌ 2 regressed benchmarks
✅ 21 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation long input burst (200 bytes) 576.1 µs 1,265.1 µs -54.46%
Simulation diff render (second frame) 690.4 µs 888.9 µs -22.33%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/size-report-rebuild (96efff6) with main (48ff4bb)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants