✨ Add glyph-cell text backgrounds#93
Open
rauhryan wants to merge 5 commits into
Open
Conversation
Packs a bg color into the pack string after decoding the bg color, its pass through to the render text method properly
commit: |
|
Size Increased — +0.3 KB 107.8 KB unpacked |
Contributor
natemoo-re
approved these changes
Jun 7, 2026
Member
There was a problem hiding this comment.
we're consolidating on test/color.test.ts for foreground/background behavior. feel free to rename this
Collaborator
Author
Added a demo to combine all the color features
|
cowboyd
reviewed
Jun 8, 2026
cowboyd
left a comment
cowboyd
left a comment
Collaborator
There was a problem hiding this comment.
Looks great 🙌🏻
Only thing I'd change is that this should probably go into color.test.ts now that we have it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packs a bg color into the pack string
after decoding the bg color, its pass through to the render text method properly
What does this PR do?
Add bg color option for text
Closes #73
Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure
I generated the tests and the changes to the render-spec but I mostly hand coded the implemenation