Skip to content

Fix BOOST_DECIMAL_DEBUG output to use correct parameter names in d64_mul_impl#1346

Merged
mborland merged 1 commit intoboostorg:developfrom
cuiweixie:bugfix/var_name_v2
Mar 21, 2026
Merged

Fix BOOST_DECIMAL_DEBUG output to use correct parameter names in d64_mul_impl#1346
mborland merged 1 commit intoboostorg:developfrom
cuiweixie:bugfix/var_name_v2

Conversation

@cuiweixie
Copy link
Contributor

No description provided.

@ckormanyos
Copy link
Member

ckormanyos commented Mar 21, 2026

Hi @cuiweixie CI has failures due to an unrelated issue in a header from Boost.Math. This is probably because of new code in Boost.Math's headers. It is the shadow-warning of a type alias. Decimal runs CI/CD with -Werror. In #1347 the warning has simply been disabled. If/when this cycles green, I can push it to develop and you can merge it into your branch.

Cc: @mborland

@ckormanyos
Copy link
Member

Hi @cuiweixie this issue has been fixed on develop. If you merge develop into your branch, CI/CD should go green again.

@cuiweixie cuiweixie force-pushed the bugfix/var_name_v2 branch from 223e0ea to 47e3947 Compare March 21, 2026 13:22
@cuiweixie
Copy link
Contributor Author

Hi @cuiweixie this issue has been fixed on develop. If you merge develop into your branch, CI/CD should go green again.

rebase. Please help to trigger ci.

@ckormanyos
Copy link
Member

rebase. Please help to trigger ci.

Thank you. CI is running.

Copy link
Member

@mborland mborland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.5%. Comparing base (472f692) to head (47e3947).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1346     +/-   ##
=========================================
+ Coverage     98.5%   98.5%   +0.1%     
=========================================
  Files          282     282             
  Lines        22550   22550             
  Branches      1960    1960             
=========================================
+ Hits         22198   22199      +1     
+ Misses         352     351      -1     
Files with missing lines Coverage Δ
include/boost/decimal/detail/mul_impl.hpp 100.0% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472f692...47e3947. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit d61b63f into boostorg:develop Mar 21, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants