Fix unchecked lower bound warning in get_default_error_string.#263
Open
PDeets wants to merge 1 commit intoboostorg:developfrom
Open
Fix unchecked lower bound warning in get_default_error_string.#263PDeets wants to merge 1 commit intoboostorg:developfrom
PDeets wants to merge 1 commit intoboostorg:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #248 by fixing a build warning on MSVC that occurs in the
get_default_error_stringfunction. The warning is due to n being used as an index without its lower bound being checked. To fix this, I'm adding a cast to the bounds comparison so it is done as unsigned. That way negative values will show up as large positive values that exceederror_unknown. For consistency with the surrounding code, I used the same syntax to define the unsigned type as is used in theis_extendedfunction on line 45.