Makefile: auto-detect btrfs headers for portable local builds#65
Merged
alicefr merged 1 commit intoJun 22, 2026
Merged
Conversation
HarshwardhanPatil07
commented
Jun 22, 2026
Contributor
- make build-bink fails on systems without btrfs-progs-devel
- Add hack/btrfs_installed_tag.sh — probes for btrfs/ioctl.h and emits exclude_graphdriver_btrfs when headers are absent (same pattern used by Podman, Buildah, and Skopeo)
- On systems with btrfs-progs-devel installed, behavior is unchanged — btrfs compiles normally
…-devel Add hack/btrfs_installed_tag.sh (same pattern as Podman/Buildah) that probes for btrfs/ioctl.h and emits exclude_graphdriver_btrfs when the headers are missing. Wire it into the Makefile via BUILDTAGS so `make build-bink` works out of the box on any system. Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
alicefr
approved these changes
Jun 22, 2026
Collaborator
|
@HarshwardhanPatil07 thanks for the PR! Looks good! |
Collaborator
|
Nice find. That requirement bothered me as well and I hadn't had time to investigate it properly. Honestly, I think we should just always pass this tag. There's no reason we need whatever btrfs-specific features in that stack since everything is done through podman remote anyway. |
|
I would suggest trying not to vendor the podman sources at all because that puts one on a huge CVE train - try to use e.g. github.com/docker/docker/client ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.