-
Notifications
You must be signed in to change notification settings - Fork 4
Save Jpar0 to output tokamak grids #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reads ffprime, pprime from geqdsk file; passes through to regions, calculates Jpar0 and saves to the output grid
H.Seto noted that in the COCOS +1 convention that Hypnotoad assumes, Jpar has a minus sign.
Used to detect when outside the core plasma. Test cases have no X-points so no psi_bdry.
Use Scipy.interpolate to differentiate w.r.t psi and save to the output geqdsk file.
Jpar0 isn't in the reference grid files so integrated tests fail.
InterpolatedUnivariateSpline requires monotonically increasing X axis, so reverse sign of psi in negative Bp case.
johnomotani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for this to go in, guess it will need updating when #183 is merged.
… expected_different_vars
Updated implementation of 'fpolprime' changes the calculated curvature-related outputs outside the separatrix.
Should return 0, but in an array with the same size as the argument `psi`, not just as a float, for compatibility with later use.
|
This PR changes the implementation of |
Reads ffprime, pprime from geqdsk file; passes through to regions, calculates Jpar0, and saves to the output grid.
doc/whats-new.mdwith a summary of the changes