Update galea_v4 config_board method to receive acknowledgements while streaming #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrey1994
reviewed
Jan 7, 2025
Member
Andrey1994
left a comment
Andrey1994
left a comment
There was a problem hiding this comment.
its not gonna work, there is another thread reading from the same socket as a result acks you are hoping to receive here will be received in another thread reading data from the board and vice versa, data you should read in the data acquisition thread will be acquired in config_board method
Member
|
Proper way to handle it would be to create multiple sockets instead |
Member
|
will close this one, feel free to create a new one and I can also help implementing it if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.