Add attestation to releases#170
Open
David Elner (delner) wants to merge 4 commits into
Open
Conversation
David Elner (delner)
requested review from
Abhijeet Prasad (AbhiPrasad),
Matt Perpick (clutchski) and
Luca Forstner (lforst)
David Elner (delner)
assigned
Andrew Kent (realark) and unassigned
Andrew Kent (realark)
David Elner (delner)
requested review from
Stephen Belanger (Qard),
Andrew Kent (realark) and
Cedric / ViaDézo1er (viadezo1er)
| \"text\": \":white_check_mark: *braintrust-sdk-ruby $TAG* has been published to RubyGems.\" | ||
| }" | ||
| -H "Content-Type: application/json; charset=utf-8" \ | ||
| -d "{\"channel\": \"$SLACK_CHANNEL\", \"text\": \"$TEXT\"}" |
There was a problem hiding this comment.
What happens if TEXT has "\ in it?
Cedric / ViaDézo1er (viadezo1er)
left a comment
Cedric / ViaDézo1er (viadezo1er)
left a comment
There was a problem hiding this comment.
Maybe ubuntu-24.04 instead of ubuntu-latest so if things break down with 26.04 we're not taken by surprise?
|
|
| uses: rubygems/configure-rubygems-credentials@a991f145d5e4a60c4b0a3ddb204f557dc1a4f985 # main | ||
| - name: Create release tag | ||
| if: ${{ !inputs.dry_run }} | ||
| run: git tag "$GITHUB_REF_NAME" |
There was a problem hiding this comment.
I think this is only creating a local tag. We may want to push it if we use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request further overhauls the release process by: