Skip to content

Remove built-in pgpass support.#3636

Merged
brianc merged 2 commits into9.0from
bmc/remove-pg-pass
Mar 6, 2026
Merged

Remove built-in pgpass support.#3636
brianc merged 2 commits into9.0from
bmc/remove-pg-pass

Conversation

@brianc
Copy link
Owner

@brianc brianc commented Mar 6, 2026

While I very much appreciate the work @hoegaarden has done w/ pgpass I think it makes sense to remove it from being built in and instead support it via an extensability mechanism of the password option accepting an async function which should return the password. This allows 1 line integration w/ pgpass but removes it from being required for installing.

@brianc brianc added the 9.0 label Mar 6, 2026
@brianc
Copy link
Owner Author

brianc commented Mar 6, 2026

@charmander @hjr3 first 9.0 PR! Branch is cut and I'll be blasting on the milestone next week!

@charmander
Copy link
Collaborator

About that Node 20 CI failure:

node: ../deps/uv/src/unix/core.c:301: uv__finish_close: Assertion `handle->flags & UV_HANDLE_CLOSING' failed.
Aborted (core dumped)

Nothing to do with this PR, but that’s a little concerning! Node bug, pg-native, or something else…?

@brianc
Copy link
Owner Author

brianc commented Mar 6, 2026

Nothing to do with this PR, but that’s a little concerning! Node bug, pg-native, or something else…?

I've never seen this anywhere outside of the CI in github actions. I'm not 100% sure what it is. I can look into it but I figured it was something flaky w/ their infra. I have received AFAIK 0 reports of this happening in real systems or even in other folk's CI so I never really prioritized it.

@charmander
Copy link
Collaborator

Temporary off-topic message because my e-mail is a little broken right now 😅:

  • I don’t have Discord, but @charmander:matrix.org is a good place to reach me!
  • Yeah, that report is mostly junk, other than highlighting the slightly surprising behaviour in the one module (which is more relevant if people use it outside a pg context). My take on it was exactly the same as yours :D

@brianc
Copy link
Owner Author

brianc commented Mar 6, 2026

Temporary off-topic message because my e-mail is a little broken right now 😅:

  • I don’t have Discord, but @charmander:matrix.org is a good place to reach me!
  • Yeah, that report is mostly junk, other than highlighting the slightly surprising behaviour in the one module (which is more relevant if people use it outside a pg context). My take on it was exactly the same as yours :D

you're amazing. ty!

@brianc brianc merged commit cb85dad into 9.0 Mar 6, 2026
21 of 22 checks passed
@brianc brianc deleted the bmc/remove-pg-pass branch March 6, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants