Skip to content

[downcast-rework-fusion]#6790

Draft
mccanne wants to merge 4 commits intomainfrom
downcast-rework-fusion
Draft

[downcast-rework-fusion]#6790
mccanne wants to merge 4 commits intomainfrom
downcast-rework-fusion

Conversation

@mccanne
Copy link
Copy Markdown
Collaborator

@mccanne mccanne commented Apr 3, 2026

No description provided.

Comment on lines 44 to 45
Copy link
Copy Markdown
Member

@nwt nwt Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this change in lieu of skipping this test and adding the test below?

(I meant to do this myself in #6769.)

diff --git a/runtime/ztests/expr/function/defuse.yaml b/runtime/ztests/expr/function/defuse.yaml
index a3ad79964..9ff77b91a 100644
--- a/runtime/ztests/expr/function/defuse.yaml
+++ b/runtime/ztests/expr/function/defuse.yaml
@@ -39,8 +39,8 @@ input: &input |
   [[1::=a1]::=a2]::=a3
   |[|[1::=s1]|::=s2]|::=s3
   |{1::=m1:2::=m2}|::=m3
+  1::=u1::(u2=(u1|(u3=string)))
   "a"::(en1=enum(a,b))
-  1::=n1::(n2=n1|(n3=string))
   error(1::=er1)::=er2

 output: *input

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I enabled the test and made the change. It's now the only test failing on this branch under the new logic.

@mccanne mccanne force-pushed the downcast-rework-fusion branch from 5be5f6a to b9fb547 Compare April 4, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants