Skip to content

vam: reduce allocations in samFunc #6792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwt merged 1 commit into from
Apr 3, 2026
Merged

vam: reduce allocations in samFunc #6792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions runtime/vam/expr/function/function.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func New(sctx *super.Context, name string, narg int) (expr.Function, error) {
case "compare":
argmin = 2
argmax = 3
f = &samFunc{sctx, function.NewCompare(sctx)}
f = newSamFunc(sctx, function.NewCompare(sctx))
case "concat":
argmin = 1
argmax = -1
Expand All @@ -46,7 +46,7 @@ func New(sctx *super.Context, name string, narg int) (expr.Function, error) {
argmax = 2
f = &DatePart{sctx}
case "defuse":
f = &samFunc{sctx, function.NewDefuse(sctx)}
f = newSamFunc(sctx, function.NewDefuse(sctx))
case "error":
f = &Error{sctx}
case "fields":
Expand Down Expand Up @@ -156,7 +156,7 @@ func New(sctx *super.Context, name string, narg int) (expr.Function, error) {
f = newUnflatten(sctx)
case "upcast":
argmin, argmax = 2, 2
f = &samFunc{sctx, function.NewUpcast(sctx)}
f = newSamFunc(sctx, function.NewUpcast(sctx))
case "upper":
f = &ToUpper{sctx}
default:
Expand All @@ -183,20 +183,25 @@ func underAll(args []vector.Any) []vector.Any {
type samFunc struct {
sctx *super.Context
fn samexpr.Function

builders []scode.Builder
values []super.Value
}

func newSamFunc(sctx *super.Context, fn samexpr.Function) *samFunc {
return &samFunc{sctx: sctx, fn: fn}
}

func (f *samFunc) Call(args ...vector.Any) vector.Any {
builders := make([]scode.Builder, len(args))
vals := make([]super.Value, len(args))
f.builders = slices.Grow(f.builders[:0], len(args))[:len(args)]
b := vector.NewDynamicBuilder()
for i := range args[0].Len() {
for k := range args {
b := &builders[k]
b.Truncate()
args[k].Serialize(b, i)
vals[k] = super.NewValue(args[k].Type(), b.Bytes().Body())
f.values = f.values[:0]
for j, vec := range args {
val := vector.ValueAt(&f.builders[j], vec, i)
f.values = append(f.values, val)
}
b.Write(f.fn.Call(vals))
b.Write(f.fn.Call(f.values))
}
return b.Build(f.sctx)
}
Loading