Skip to content

agg distinct: Fix view generation in ConsumeAsPartial#6793

Merged
mattnibs merged 1 commit intomainfrom
agg-distinct.ConsumeAsPartial
Apr 3, 2026
Merged

agg distinct: Fix view generation in ConsumeAsPartial#6793
mattnibs merged 1 commit intomainfrom
agg-distinct.ConsumeAsPartial

Conversation

@mattnibs
Copy link
Copy Markdown
Collaborator

@mattnibs mattnibs commented Apr 3, 2026

Closes #6785

@mattnibs mattnibs requested a review from a team April 3, 2026 22:26
start, end := vector.ContainerOffset(array, slot)
values := array.Values
if start > 0 || end < vec.Len() {
if start > 0 || end < values.Len() {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha!

@mattnibs mattnibs merged commit 828aacf into main Apr 3, 2026
2 checks passed
@mattnibs mattnibs deleted the agg-distinct.ConsumeAsPartial branch April 3, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL: Incorrect/inconsistent aggregation on JSON in vector runtime

2 participants