vbuild.Union: Use run length encoding when possible#6968
Merged
Conversation
mattnibs
force-pushed
the
vbuild-union-rle
branch
3 times, most recently
from
f233ddc to
0731ba9
Compare
nwt
reviewed
May 19, 2026
Member
nwt
left a comment
nwt
left a comment
There was a problem hiding this comment.
vector/vbuild/union.go appears to duplicate a lot of code from csup/union.go. Can it be shared instead?
Collaborator
Author
|
@nwt working on that, this is the first step. |
Collaborator
Author
|
Meaning all the Builder-like code in csup is going away and is going to use |
nwt
reviewed
May 20, 2026
nwt
reviewed
May 20, 2026
Comment on lines
+48
to
+49
| vecs, rle = reorderRLE(union, rle) | ||
| u.tags = concatRLEs(u.tags, rle) |
Member
There was a problem hiding this comment.
This is different from what's in csup/union.go:
// RLEs have the nice property that you can just concatenate them
// to append two vectors.
vecs, rle = reorderRLE(union, rle)
u.tags = append(u.tags, rle...)Is the comment about concatenation wrong?
mattnibs
force-pushed
the
vbuild-union-rle
branch
from
0731ba9 to
16e7ec1
Compare
nwt
approved these changes
May 20, 2026
mattnibs
force-pushed
the
vbuild-union-rle
branch
from
16e7ec1 to
ae9a33c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.