Skip to content

fix(consensus): DB GC stall in deep sync#1057

Draft
Mododo wants to merge 1 commit intomasterfrom
fix/consensus/commit-watch
Draft

fix(consensus): DB GC stall in deep sync#1057
Mododo wants to merge 1 commit intomasterfrom
fix/consensus/commit-watch

Conversation

@Mododo
Copy link
Copy Markdown
Member

@Mododo Mododo commented Mar 24, 2026

removes redundant commit watch

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

None

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full

SPECIAL DEPLOYMENT ACTIONS

Not Required


PERFORMANCE IMPACT

No impact expected


TESTS

Unit Tests

No coverage

Network Tests

No coverage

Manual Tests

transfers-30k


Notes/Additional Comments:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1057

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1057
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1057 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@Mododo Mododo self-assigned this Mar 24, 2026
@Mododo Mododo added the C-consesus Consesus module label Mar 24, 2026
@Mododo Mododo added this to the 020 Consensus milestone Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.95%. Comparing base (e3d9768) to head (e9c534e).

Files with missing lines Patch % Lines
consensus/src/test_utils/anchor_consumer.rs 0.00% 15 Missing ⚠️
collator/src/mempool/impls/std_impl/mod.rs 0.00% 4 Missing ⚠️
consensus/src/storage/db_cleaner.rs 0.00% 4 Missing ⚠️
consensus/src/engine/impl_.rs 0.00% 2 Missing ⚠️
...lator/src/mempool/impls/std_impl/anchor_handler.rs 0.00% 1 Missing ⚠️
consensus/src/engine/committer_task.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
- Coverage   56.97%   56.95%   -0.02%     
==========================================
  Files         431      431              
  Lines       72637    72602      -35     
  Branches    72637    72602      -35     
==========================================
- Hits        41382    41354      -28     
+ Misses      29257    29246      -11     
- Partials     1998     2002       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mododo Mododo requested a review from 0xdeafbeef March 24, 2026 14:17
* remove redundant commit watch
@Mododo Mododo force-pushed the fix/consensus/commit-watch branch from c9280bb to e9c534e Compare March 24, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-consesus Consesus module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant