Skip to content

Feature/improved collation cancel#1063

Draft
drmick wants to merge 2 commits intobroxus:masterfrom
drmick:feature/improved-collation-cancel
Draft

Feature/improved collation cancel#1063
drmick wants to merge 2 commits intobroxus:masterfrom
drmick:feature/improved-collation-cancel

Conversation

@drmick
Copy link
Copy Markdown
Contributor

@drmick drmick commented Apr 1, 2026

  • Removed CancelPending and simplified collator state management to Active/Waiting/Cancelled.
  • Added a new command_complete notify signal from collator to manager.
  • Implemented cancel_active_collators(...) in the manager: it marks active collators as cancelled, sends graceful cancel, and waits for the current
    command to finish.
  • Updated mismatch/sync paths to explicitly cancel active collators and wait before running sync.
  • Treated ExternalCancel as an internal graceful-cancel path (no regular on_cancelled dispatch handling).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant