Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
| }, | ||
| { | ||
| "name": "c8ca5bce5cbabac76b8619bd8d63ac10bb0561a9", | ||
| "digest": "9a5442db8abc197ab883481e6de9c5ea625135cc4301acb79b350f595434d2b459417ee88e8bf8f80f152cc4a21cf9deb5da75e13d2660a23214e97ba79cbfd2" |
There was a problem hiding this comment.
[Updated at 2026-04-08T22:21:51Z]
Intermediate transition
$ casdiff 76fdbf751250953a27e0c58f9e8f8489aa84ae7c \
c8ca5bce5cbabac76b8619bd8d63ac10bb0561a9 \
--format=markdown5 files changed: 0 removed, 0 renamed, 0 added, 5 changed content.
5 files changed: 0 removed, 0 renamed, 0 added, 5 changed content.
Files changed content:
google/api/expr/v1alpha1/checked.proto:
--- shake256:9b9c4c5bd72d6d649da60d3d9b24b16a9535411ce73e47d22c475d2e8437095b2f7cbd8823e8ac7a237838e76daed32124651c6b4144302e45ea143bfb68624b google/api/expr/v1alpha1/checked.proto
+++ shake256:54394c1b59899cbf6ecee3a23c4d55861ff36e61f52b6e54e25d12c901bc9cec719a718a552aeda520d4cb9886e25a8c9fd62a0bacdcfae31aedb2ca3319d54a google/api/expr/v1alpha1/checked.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
import "google/protobuf/empty.proto";
import "google/protobuf/struct.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "DeclProto";
@@ -291,12 +290,41 @@
// expected type of the target receiver.
bool is_instance_function = 5;
- // Documentation string for the overload.
+ // Examples for the overload and its expected return value, separated by
+ // newlines.
+ //
+ // Prefer using CEL literals in examples as they are easily consumed by
+ // humans and simple to validate with machines. The example should contain
+ // an expression with a literal return value in comments inline. If the
+ // expression example is too complex or would need an example for a
+ // variable that cannot be expressed in CEL, document the input and return
+ // in a comment preceding the example.
+ //
+ // Examples:
+ //
+ // 1 in [1, 2, 3] // true
+ // 'key' in {'key1: 1, 'key2': 2} // false
+ // // Test whether one or more keys exist within a map.
+ // // returns true if list_of_keys contains 'key2' or 'key3'
+ // list_of_keys.exists(key, key in {'key3': 1, 'key2': 2})
string doc = 6;
}
// Required. List of function overloads, must contain at least one overload.
repeated Overload overloads = 1;
+
+ // Documentation string for the function that indicates the general purpose
+ // of the function and its behavior.
+ //
+ // Documentation strings for the function should be general purpose with
+ // specific examples provided in the overload doc string.
+ //
+ // Examples:
+ //
+ // The 'in' operator tests whether an item exists in a collection.
+ //
+ // The 'substring' function returns a substring of a target string.
+ string doc = 2;
}
// The fully qualified name of the declaration.
google/api/expr/v1alpha1/eval.proto:
--- shake256:de425c43fbee60514d30321f148481e942a53fbb8619b6d96e46f8969affa38e074f4d9194c21eed7bed2a13964fc61687f0daf6d06999126c39958d33793cb5 google/api/expr/v1alpha1/eval.proto
+++ shake256:82459cd88b16c1cb2bbaae6d3bef2ef1416add589ef204155de6ec0d00eaeb53bc219fae1645b8ee56ff2f14dd8c8c2974bdfc3cb037c55715349554ae6ae6ba google/api/expr/v1alpha1/eval.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -19,7 +19,6 @@
import "google/api/expr/v1alpha1/value.proto";
import "google/rpc/status.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "EvalProto";
@@ -27,11 +26,11 @@
// The state of an evaluation.
//
-// Can represent an inital, partial, or completed state of evaluation.
+// Can represent an initial, partial, or completed state of evaluation.
message EvalState {
- // A single evalution result.
+ // A single evaluation result.
message Result {
- // The id of the expression this result if for.
+ // The id of the expression this result is for.
int64 expr = 1;
// The index in `values` of the resulting value.
@@ -55,14 +54,14 @@
// A concrete value.
Value value = 1;
- // The set of errors in the critical path of evalution.
+ // The set of errors in the critical path of evaluation.
//
// Only errors in the critical path are included. For example,
// `(<error1> || true) && <error2>` will only result in `<error2>`,
// while `<error1> || <error2>` will result in both `<error1>` and
// `<error2>`.
//
- // Errors cause by the presence of other errors are not included in the
+ // Errors caused by the presence of other errors are not included in the
// set. For example `<error1>.foo`, `foo(<error1>)`, and `<error1> + 1` will
// only result in `<error1>`.
//
@@ -87,13 +86,13 @@
// foo(<unknown[1]>) -> <unknown[1]>
// <unknown[1]> + <unknown[2]> -> <unknown[1]> or <unknown[2[>
//
- // Unknown takes precidence over Error in cases where a `Value` can short
+ // Unknown takes precedence over Error in cases where a `Value` can short
// circuit the result:
//
// <error> || <unknown> -> <unknown>
// <error> && <unknown> -> <unknown>
//
- // Errors take precidence in all other cases:
+ // Errors take precedence in all other cases:
//
// <unknown> + <error> -> <error>
// foo(<unknown>, <error>) -> <error>
google/api/expr/v1alpha1/explain.proto:
--- shake256:b44d8c8de74757e48969d9c6495fa2723b773b6c0e10bafbea5d0f23128c9bcb5982dfa5a4d28185a140287f2d18f4ea4f3745636ba2094f2c529738b5e88956 google/api/expr/v1alpha1/explain.proto
+++ shake256:0d501640d39656f494ec6c6783c4062128f8733600b41be8650d783ac151daa9cd17d42c30bb8e8592859fac1690700062f709d12ee21cdb2a768eef220597f9 google/api/expr/v1alpha1/explain.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -18,7 +18,6 @@
import "google/api/expr/v1alpha1/value.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "ExplainProto";
google/api/expr/v1alpha1/syntax.proto:
--- shake256:e2fefad26ca4981dc4e48ca80a02b4abc54a8b8c959bc24e67f045ed31b3d2a4b86e959879c0ecde4682b304c8979814ebf92409606cf2b265c4f2a0b36935a0 google/api/expr/v1alpha1/syntax.proto
+++ shake256:19e9a802acf52feeb84d9fc117d6f7a9bba4b740726f244bb79d6636a05acb67a67985187f2633c7a5270c70e546b88b10445e02ea15d5e7665d7ecb8f595b62 google/api/expr/v1alpha1/syntax.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
import "google/protobuf/struct.proto";
import "google/protobuf/timestamp.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "SyntaxProto";
@@ -42,12 +41,12 @@
// Expressions are abstractly represented as a collection of identifiers,
// select statements, function calls, literals, and comprehensions. All
// operators with the exception of the '.' operator are modelled as function
-// calls. This makes it easy to represent new operators into the existing AST.
+// calls. This makes it easy to represent new operators in the existing AST.
//
// All references within expressions must resolve to a
// [Decl][google.api.expr.v1alpha1.Decl] provided at type-check for an
// expression to be valid. A reference may either be a bare identifier `name` or
-// a qualified identifier `google.api.name`. References may either refer to a
+// a qualified identifier `google.api.name`. References may refer to either a
// value or a function declaration.
//
// For example, the expression `google.api.name.startsWith('expr')` references
@@ -89,7 +88,7 @@
//
// For example, `value == 10`, `size(map_value)`.
message Call {
- // The target of an method call-style expression. For example, `x` in
+ // The target of a method call-style expression. For example, `x` in
// `x.f()`.
Expr target = 1;
@@ -102,7 +101,7 @@
// A list creation expression.
//
- // Lists may either be homogenous, e.g. `[1, 2, 3]`, or heterogeneous, e.g.
+ // Lists may either be homogeneous, e.g. `[1, 2, 3]`, or heterogeneous, e.g.
// `dyn([1, 'hello', 2.0])`
message CreateList {
// The elements part of the list.
@@ -127,7 +126,7 @@
message Entry {
// Required. An id assigned to this node by the parser which is unique
// in a given expression tree. This is used to associate type
- // information and other attributes to the node.
+ // information and other attributes with the node.
int64 id = 1;
// The `Entry` key kinds.
@@ -150,7 +149,7 @@
bool optional_entry = 5;
}
- // The type name of the message to be created, empty when creating map
+ // The type name of the message to be created; empty when creating map
// literals.
string message_name = 1;
@@ -181,7 +180,7 @@
//
// The `has(m.x)` macro tests whether the property `x` is present in struct
// `m`. The semantics of this macro depend on the type of `m`. For proto2
- // messages `has(m.x)` is defined as 'defined, but not set`. For proto3, the
+ // messages `has(m.x)` is defined as 'defined, but not set'. For proto3, the
// macro tests whether the property is set to its default. For map and struct
// types, the macro tests whether the property `x` is defined on `m`.
//
@@ -201,7 +200,7 @@
//
// Comprehensions for the optional V2 macros which support map-to-map
// translation differ slightly from the standard environment macros in that
- // they expose both the key or index in addition to the value for each list
+ // they expose the key or index in addition to the value for each list
// or map entry:
//
// ```
@@ -216,13 +215,12 @@
// ```
message Comprehension {
// The name of the first iteration variable.
- // When the iter_range is a list, this variable is the list element.
- // When the iter_range is a map, this variable is the map entry key.
+ // For the single iteration variable macros, when iter_range is a list, this
+ // variable is the list element and when the iter_range is a map, this
+ // variable is the map key.
string iter_var = 1;
- // The name of the second iteration variable, empty if not set.
- // When the iter_range is a list, this variable is the integer index.
- // When the iter_range is a map, this variable is the map entry value.
+ // The name of the second iteration variable; empty if not set.
// This field is only set for comprehension v2 macros.
string iter_var2 = 8;
@@ -254,7 +252,7 @@
// Required. An id assigned to this node by the parser which is unique in a
// given expression tree. This is used to associate type information and other
- // attributes to a node in the parse tree.
+ // attributes with a node in the parse tree.
int64 id = 2;
// Required. Variants of expressions.
@@ -286,7 +284,7 @@
//
// Named 'Constant' here for backwards compatibility.
//
-// This is similar as the primitives supported in the well-known type
+// This is similar to the primitives supported in the well-known type
// `google.protobuf.Value`, but richer so it can represent CEL's full range of
// primitives.
//
@@ -322,12 +320,12 @@
// protobuf.Duration value.
//
- // Deprecated: duration is no longer considered a builtin cel type.
+ // Deprecated: duration is no longer considered a builtin CEL type.
google.protobuf.Duration duration_value = 8 [deprecated = true];
// protobuf.Timestamp value.
//
- // Deprecated: timestamp is no longer considered a builtin cel type.
+ // Deprecated: timestamp is no longer considered a builtin CEL type.
google.protobuf.Timestamp timestamp_value = 9 [deprecated = true];
}
}
@@ -370,7 +368,7 @@
// If set, the listed components must understand the extension for the
// expression to evaluate correctly.
//
- // This field has set semantics, repeated values should be deduplicated.
+ // This field has set semantics; repeated values should be deduplicated.
repeated Component affected_components = 2;
// Version info. May be skipped if it isn't meaningful for the extension.
@@ -393,7 +391,7 @@
//
// The line number of a given position is the index `i` where for a given
// `id` the `line_offsets[i] < id_positions[id] < line_offsets[i+1]`. The
- // column may be derivd from `id_positions[id] - line_offsets[i]`.
+ // column may be derived from `id_positions[id] - line_offsets[i]`.
repeated int32 line_offsets = 3;
// A map from the parse node id (e.g. `Expr.id`) to the code point offset
@@ -422,7 +420,7 @@
// A specific position in source.
message SourcePosition {
- // The soucre location name (e.g. file name).
+ // The source location name (e.g. file name).
string location = 1;
// The UTF-8 code unit offset.
google/api/expr/v1alpha1/value.proto:
--- shake256:136a91d18a0eef68cea1ffb3b953bb36b2ccf16566fee27de0632a9e0102847946335f5a66c6ea22ceba1b1359fbb49381d01ff3eb34b91f813853e4e4a047f3 google/api/expr/v1alpha1/value.proto
+++ shake256:95c1fe140310e9be08fe1f0086bd05c7f0c356d0c5331bae2486b45064d9230c985e18e92546326f933c585e64ffea4c58559c74044a489f1c7ec0dc300968d1 google/api/expr/v1alpha1/value.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -19,7 +19,6 @@
import "google/protobuf/any.proto";
import "google/protobuf/struct.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "ValueProto";
@@ -109,7 +108,7 @@
// The set of map entries.
//
- // CEL has fewer restrictions on keys, so a protobuf map represenation
+ // CEL has fewer restrictions on keys, so a protobuf map representation
// cannot be used.
repeated Entry entries = 1;
}
| }, | ||
| { | ||
| "name": "6877af37b138d9c35f0489346e1224a141bb0697", | ||
| "digest": "c62ecead9b13485a02893cd678a6c81e40879bf00ea509bbc6fd8f1b2cc33eccf6a85c259b08d1e0f052f693cbfc7dfda236e9665b1d6869b8e1132a794a61e2" |
There was a problem hiding this comment.
[Updated at 2026-04-08T22:21:52Z]
Intermediate transition
$ casdiff cd090841ab172574e740c214c99df00aef9c0dee \
6877af37b138d9c35f0489346e1224a141bb0697 \
--format=markdown1 files changed: 0 removed, 0 renamed, 0 added, 1 changed content.
1 files changed: 0 removed, 0 renamed, 0 added, 1 changed content.
Files changed content:
buf.md:
--- shake256:a483c3b87b116f15dedc9b0183ce54ba921720bccf1a90dd85362cdca7312af2891689079874a214d1f9c4c8e50050542a8e3d0cc21f13d9fdae14f9dbf284be buf.md
+++ shake256:a03f3e3db996f1a04bfb5e37501893082ab5a58fd9cf84975409e402a50c4b3b29be074c83afa0dfbd378e3b4b4566ec3002171a95c7355a8e74e789887e91a8 buf.md
@@ -17,7 +17,7 @@
developers, and these files are the most common dependency in the Protobuf ecosystem. This hosted
module only includes these specific files, as including all the files causes hundreds of megabytes
of unused generated code for the vast majority of developers. To use Google's core APIs, create your
-own module that has a `dep` on `buf.build/googleapis/googleapis` with the specific packages you want
+own module that has a `dep` on `{{bsrhost}}/googleapis/googleapis` with the specific packages you want
to use.
Updates to the [source repository](https://github.com/googleapis/googleapis) are automatically
@@ -27,7 +27,7 @@
```
deps:
- - buf.build/googleapis/googleapis:<GIT_COMMIT_TAG>
+ - {{bsrhost}}/googleapis/googleapis:<GIT_COMMIT_TAG>
```
For more information, see the [documentation](https://buf.build/docs/bsr/overview).
modules/sync/state.json
Outdated
| { | ||
| "module_name": "googleapis/googleapis", | ||
| "latest_reference": "15681782525ddbe52ae581b43d5c66c9ee813e2e" | ||
| "latest_reference": "2233f63baf69c2a481f30180045fcf036242781d" |
There was a problem hiding this comment.
[Updated at 2026-04-08T22:21:52Z]
Global transition
$ casdiff 15681782525ddbe52ae581b43d5c66c9ee813e2e \
2233f63baf69c2a481f30180045fcf036242781d \
--format=markdown6 files changed: 0 removed, 0 renamed, 0 added, 6 changed content.
Files changed content:
buf.md:
--- shake256:a483c3b87b116f15dedc9b0183ce54ba921720bccf1a90dd85362cdca7312af2891689079874a214d1f9c4c8e50050542a8e3d0cc21f13d9fdae14f9dbf284be buf.md
+++ shake256:a03f3e3db996f1a04bfb5e37501893082ab5a58fd9cf84975409e402a50c4b3b29be074c83afa0dfbd378e3b4b4566ec3002171a95c7355a8e74e789887e91a8 buf.md
@@ -17,7 +17,7 @@
developers, and these files are the most common dependency in the Protobuf ecosystem. This hosted
module only includes these specific files, as including all the files causes hundreds of megabytes
of unused generated code for the vast majority of developers. To use Google's core APIs, create your
-own module that has a `dep` on `buf.build/googleapis/googleapis` with the specific packages you want
+own module that has a `dep` on `{{bsrhost}}/googleapis/googleapis` with the specific packages you want
to use.
Updates to the [source repository](https://github.com/googleapis/googleapis) are automatically
@@ -27,7 +27,7 @@
```
deps:
- - buf.build/googleapis/googleapis:<GIT_COMMIT_TAG>
+ - {{bsrhost}}/googleapis/googleapis:<GIT_COMMIT_TAG>
```
For more information, see the [documentation](https://buf.build/docs/bsr/overview).
google/api/expr/v1alpha1/checked.proto:
--- shake256:9b9c4c5bd72d6d649da60d3d9b24b16a9535411ce73e47d22c475d2e8437095b2f7cbd8823e8ac7a237838e76daed32124651c6b4144302e45ea143bfb68624b google/api/expr/v1alpha1/checked.proto
+++ shake256:54394c1b59899cbf6ecee3a23c4d55861ff36e61f52b6e54e25d12c901bc9cec719a718a552aeda520d4cb9886e25a8c9fd62a0bacdcfae31aedb2ca3319d54a google/api/expr/v1alpha1/checked.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
import "google/protobuf/empty.proto";
import "google/protobuf/struct.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "DeclProto";
@@ -291,12 +290,41 @@
// expected type of the target receiver.
bool is_instance_function = 5;
- // Documentation string for the overload.
+ // Examples for the overload and its expected return value, separated by
+ // newlines.
+ //
+ // Prefer using CEL literals in examples as they are easily consumed by
+ // humans and simple to validate with machines. The example should contain
+ // an expression with a literal return value in comments inline. If the
+ // expression example is too complex or would need an example for a
+ // variable that cannot be expressed in CEL, document the input and return
+ // in a comment preceding the example.
+ //
+ // Examples:
+ //
+ // 1 in [1, 2, 3] // true
+ // 'key' in {'key1: 1, 'key2': 2} // false
+ // // Test whether one or more keys exist within a map.
+ // // returns true if list_of_keys contains 'key2' or 'key3'
+ // list_of_keys.exists(key, key in {'key3': 1, 'key2': 2})
string doc = 6;
}
// Required. List of function overloads, must contain at least one overload.
repeated Overload overloads = 1;
+
+ // Documentation string for the function that indicates the general purpose
+ // of the function and its behavior.
+ //
+ // Documentation strings for the function should be general purpose with
+ // specific examples provided in the overload doc string.
+ //
+ // Examples:
+ //
+ // The 'in' operator tests whether an item exists in a collection.
+ //
+ // The 'substring' function returns a substring of a target string.
+ string doc = 2;
}
// The fully qualified name of the declaration.
google/api/expr/v1alpha1/eval.proto:
--- shake256:de425c43fbee60514d30321f148481e942a53fbb8619b6d96e46f8969affa38e074f4d9194c21eed7bed2a13964fc61687f0daf6d06999126c39958d33793cb5 google/api/expr/v1alpha1/eval.proto
+++ shake256:82459cd88b16c1cb2bbaae6d3bef2ef1416add589ef204155de6ec0d00eaeb53bc219fae1645b8ee56ff2f14dd8c8c2974bdfc3cb037c55715349554ae6ae6ba google/api/expr/v1alpha1/eval.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -19,7 +19,6 @@
import "google/api/expr/v1alpha1/value.proto";
import "google/rpc/status.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "EvalProto";
@@ -27,11 +26,11 @@
// The state of an evaluation.
//
-// Can represent an inital, partial, or completed state of evaluation.
+// Can represent an initial, partial, or completed state of evaluation.
message EvalState {
- // A single evalution result.
+ // A single evaluation result.
message Result {
- // The id of the expression this result if for.
+ // The id of the expression this result is for.
int64 expr = 1;
// The index in `values` of the resulting value.
@@ -55,14 +54,14 @@
// A concrete value.
Value value = 1;
- // The set of errors in the critical path of evalution.
+ // The set of errors in the critical path of evaluation.
//
// Only errors in the critical path are included. For example,
// `(<error1> || true) && <error2>` will only result in `<error2>`,
// while `<error1> || <error2>` will result in both `<error1>` and
// `<error2>`.
//
- // Errors cause by the presence of other errors are not included in the
+ // Errors caused by the presence of other errors are not included in the
// set. For example `<error1>.foo`, `foo(<error1>)`, and `<error1> + 1` will
// only result in `<error1>`.
//
@@ -87,13 +86,13 @@
// foo(<unknown[1]>) -> <unknown[1]>
// <unknown[1]> + <unknown[2]> -> <unknown[1]> or <unknown[2[>
//
- // Unknown takes precidence over Error in cases where a `Value` can short
+ // Unknown takes precedence over Error in cases where a `Value` can short
// circuit the result:
//
// <error> || <unknown> -> <unknown>
// <error> && <unknown> -> <unknown>
//
- // Errors take precidence in all other cases:
+ // Errors take precedence in all other cases:
//
// <unknown> + <error> -> <error>
// foo(<unknown>, <error>) -> <error>
google/api/expr/v1alpha1/explain.proto:
--- shake256:b44d8c8de74757e48969d9c6495fa2723b773b6c0e10bafbea5d0f23128c9bcb5982dfa5a4d28185a140287f2d18f4ea4f3745636ba2094f2c529738b5e88956 google/api/expr/v1alpha1/explain.proto
+++ shake256:0d501640d39656f494ec6c6783c4062128f8733600b41be8650d783ac151daa9cd17d42c30bb8e8592859fac1690700062f709d12ee21cdb2a768eef220597f9 google/api/expr/v1alpha1/explain.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -18,7 +18,6 @@
import "google/api/expr/v1alpha1/value.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "ExplainProto";
google/api/expr/v1alpha1/syntax.proto:
--- shake256:e2fefad26ca4981dc4e48ca80a02b4abc54a8b8c959bc24e67f045ed31b3d2a4b86e959879c0ecde4682b304c8979814ebf92409606cf2b265c4f2a0b36935a0 google/api/expr/v1alpha1/syntax.proto
+++ shake256:19e9a802acf52feeb84d9fc117d6f7a9bba4b740726f244bb79d6636a05acb67a67985187f2633c7a5270c70e546b88b10445e02ea15d5e7665d7ecb8f595b62 google/api/expr/v1alpha1/syntax.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
import "google/protobuf/struct.proto";
import "google/protobuf/timestamp.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "SyntaxProto";
@@ -42,12 +41,12 @@
// Expressions are abstractly represented as a collection of identifiers,
// select statements, function calls, literals, and comprehensions. All
// operators with the exception of the '.' operator are modelled as function
-// calls. This makes it easy to represent new operators into the existing AST.
+// calls. This makes it easy to represent new operators in the existing AST.
//
// All references within expressions must resolve to a
// [Decl][google.api.expr.v1alpha1.Decl] provided at type-check for an
// expression to be valid. A reference may either be a bare identifier `name` or
-// a qualified identifier `google.api.name`. References may either refer to a
+// a qualified identifier `google.api.name`. References may refer to either a
// value or a function declaration.
//
// For example, the expression `google.api.name.startsWith('expr')` references
@@ -89,7 +88,7 @@
//
// For example, `value == 10`, `size(map_value)`.
message Call {
- // The target of an method call-style expression. For example, `x` in
+ // The target of a method call-style expression. For example, `x` in
// `x.f()`.
Expr target = 1;
@@ -102,7 +101,7 @@
// A list creation expression.
//
- // Lists may either be homogenous, e.g. `[1, 2, 3]`, or heterogeneous, e.g.
+ // Lists may either be homogeneous, e.g. `[1, 2, 3]`, or heterogeneous, e.g.
// `dyn([1, 'hello', 2.0])`
message CreateList {
// The elements part of the list.
@@ -127,7 +126,7 @@
message Entry {
// Required. An id assigned to this node by the parser which is unique
// in a given expression tree. This is used to associate type
- // information and other attributes to the node.
+ // information and other attributes with the node.
int64 id = 1;
// The `Entry` key kinds.
@@ -150,7 +149,7 @@
bool optional_entry = 5;
}
- // The type name of the message to be created, empty when creating map
+ // The type name of the message to be created; empty when creating map
// literals.
string message_name = 1;
@@ -181,7 +180,7 @@
//
// The `has(m.x)` macro tests whether the property `x` is present in struct
// `m`. The semantics of this macro depend on the type of `m`. For proto2
- // messages `has(m.x)` is defined as 'defined, but not set`. For proto3, the
+ // messages `has(m.x)` is defined as 'defined, but not set'. For proto3, the
// macro tests whether the property is set to its default. For map and struct
// types, the macro tests whether the property `x` is defined on `m`.
//
@@ -201,7 +200,7 @@
//
// Comprehensions for the optional V2 macros which support map-to-map
// translation differ slightly from the standard environment macros in that
- // they expose both the key or index in addition to the value for each list
+ // they expose the key or index in addition to the value for each list
// or map entry:
//
// ```
@@ -216,13 +215,12 @@
// ```
message Comprehension {
// The name of the first iteration variable.
- // When the iter_range is a list, this variable is the list element.
- // When the iter_range is a map, this variable is the map entry key.
+ // For the single iteration variable macros, when iter_range is a list, this
+ // variable is the list element and when the iter_range is a map, this
+ // variable is the map key.
string iter_var = 1;
- // The name of the second iteration variable, empty if not set.
- // When the iter_range is a list, this variable is the integer index.
- // When the iter_range is a map, this variable is the map entry value.
+ // The name of the second iteration variable; empty if not set.
// This field is only set for comprehension v2 macros.
string iter_var2 = 8;
@@ -254,7 +252,7 @@
// Required. An id assigned to this node by the parser which is unique in a
// given expression tree. This is used to associate type information and other
- // attributes to a node in the parse tree.
+ // attributes with a node in the parse tree.
int64 id = 2;
// Required. Variants of expressions.
@@ -286,7 +284,7 @@
//
// Named 'Constant' here for backwards compatibility.
//
-// This is similar as the primitives supported in the well-known type
+// This is similar to the primitives supported in the well-known type
// `google.protobuf.Value`, but richer so it can represent CEL's full range of
// primitives.
//
@@ -322,12 +320,12 @@
// protobuf.Duration value.
//
- // Deprecated: duration is no longer considered a builtin cel type.
+ // Deprecated: duration is no longer considered a builtin CEL type.
google.protobuf.Duration duration_value = 8 [deprecated = true];
// protobuf.Timestamp value.
//
- // Deprecated: timestamp is no longer considered a builtin cel type.
+ // Deprecated: timestamp is no longer considered a builtin CEL type.
google.protobuf.Timestamp timestamp_value = 9 [deprecated = true];
}
}
@@ -370,7 +368,7 @@
// If set, the listed components must understand the extension for the
// expression to evaluate correctly.
//
- // This field has set semantics, repeated values should be deduplicated.
+ // This field has set semantics; repeated values should be deduplicated.
repeated Component affected_components = 2;
// Version info. May be skipped if it isn't meaningful for the extension.
@@ -393,7 +391,7 @@
//
// The line number of a given position is the index `i` where for a given
// `id` the `line_offsets[i] < id_positions[id] < line_offsets[i+1]`. The
- // column may be derivd from `id_positions[id] - line_offsets[i]`.
+ // column may be derived from `id_positions[id] - line_offsets[i]`.
repeated int32 line_offsets = 3;
// A map from the parse node id (e.g. `Expr.id`) to the code point offset
@@ -422,7 +420,7 @@
// A specific position in source.
message SourcePosition {
- // The soucre location name (e.g. file name).
+ // The source location name (e.g. file name).
string location = 1;
// The UTF-8 code unit offset.
google/api/expr/v1alpha1/value.proto:
--- shake256:136a91d18a0eef68cea1ffb3b953bb36b2ccf16566fee27de0632a9e0102847946335f5a66c6ea22ceba1b1359fbb49381d01ff3eb34b91f813853e4e4a047f3 google/api/expr/v1alpha1/value.proto
+++ shake256:95c1fe140310e9be08fe1f0086bd05c7f0c356d0c5331bae2486b45064d9230c985e18e92546326f933c585e64ffea4c58559c74044a489f1c7ec0dc300968d1 google/api/expr/v1alpha1/value.proto
@@ -1,4 +1,4 @@
-// Copyright 2025 Google LLC
+// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -19,7 +19,6 @@
import "google/protobuf/any.proto";
import "google/protobuf/struct.proto";
-option cc_enable_arenas = true;
option go_package = "google.golang.org/genproto/googleapis/api/expr/v1alpha1;expr";
option java_multiple_files = true;
option java_outer_classname = "ValueProto";
@@ -109,7 +108,7 @@
// The set of map entries.
//
- // CEL has fewer restrictions on keys, so a protobuf map represenation
+ // CEL has fewer restrictions on keys, so a protobuf map representation
// cannot be used.
repeated Entry entries = 1;
}
… diffs - Prefix intermediate per-module comments with "**Intermediate transition**" - Prefix global state comments with "### Global transition" - Use a dynamic code fence in markdown diff output to avoid broken rendering when the diffed file itself contains triple-backtick sequences (e.g. buf.md)
This reverts commit e8c73c3.
pkwarren
approved these changes
Apr 8, 2026
pkwarren
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to per-transition inline comments, post a single overall comment on
modules/sync/state.jsonshowing the end-to-end change (base → head latest reference) for each module that changed — giving reviewers a quick summary of what BSR main will see after sync without reading every intermediate step.<details>block and labeled Intermediate transitionlatest_referenceline in the global state file and labeled Global transitionbuf.md) contains triple-backtick sequences inside its own diffTested: See automatic comments on this same PR.