feat(config): add credential_store key#854
Open
ivannalisetska wants to merge 1 commit into
Open
Conversation
- Add credential_store config key (auto, keyring, shm) with precedence env > local > user - Propagate the configured value into BUILDKITE_CREDENTIAL_STORE at startup so bk auth login uses it without --credential-store - Update help text on bk config set/get and bk auth login TASK: SUP-7238
mcncl
reviewed
Jun 6, 2026
|
|
||
| // Must run before kong dispatches: bk auth login builds its keyring | ||
| // before factory.New() does. | ||
| factory.ApplyCredentialStoreFromConfig(conf) |
Contributor
There was a problem hiding this comment.
Hmm, I don't think this would recognise a local config unless --credential-store is also passed, eg bk auth login --local wouldn't respect a local .bk.yaml config being present.
We'd need to ensure login respects --local config, or only support user configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASK: SUP-7238
Description
Changes
Add credential_store key to bk config (auto, keyring, shm).
Wire it through bk config set/get/list/unset with validation.
Export the configured value into BUILDKITE_CREDENTIAL_STORE at process start so every command (notably bk auth login) picks it up without flags.
Precedence: --credential-store flag > env > local config > user config > auto.
Update help text on bk config set/get and bk auth login.
Unit tests for the new key, precedence chain, and the env bridge.
Can skip if changes are simple or clear from the commit messages.
-->
Testing
go test ./...) 39 packages, all ok, zero failures.go fmt ./...) no files needed reformatting.Disclosures / Credits