Skip to content

Fix sign-compare warnings #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lum1n0us merged 1 commit into from
Mar 18, 2026
+6 −2
Merged

Fix sign-compare warnings #4876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,9 @@ fd_table_attach(struct fd_table *ft, __wasi_fd_t fd, struct fd_object *fo,
__wasi_rights_t rights_base, __wasi_rights_t rights_inheriting)
REQUIRES_EXCLUSIVE(ft->lock) CONSUMES(fo->refcount)
{
bh_assert(ft->size > (size_t)fd && "File descriptor table too small");
bh_assert(ft->size <= INT_MAX
&& "Unsigned value is out of signed int range");
bh_assert((int32_t)ft->size > fd && "File descriptor table too small");
struct fd_entry *fe = &ft->entries[fd];
bh_assert(fe->object == NULL
&& "Attempted to overwrite an existing descriptor");
Expand All @@ -446,7 +448,9 @@ static void
fd_table_detach(struct fd_table *ft, __wasi_fd_t fd, struct fd_object **fo)
REQUIRES_EXCLUSIVE(ft->lock) PRODUCES((*fo)->refcount)
{
bh_assert(ft->size > fd && "File descriptor table too small");
bh_assert(ft->size <= INT_MAX
&& "Unsigned value is out of signed int range");
bh_assert((int32_t)ft->size > fd && "File descriptor table too small");
struct fd_entry *fe = &ft->entries[fd];
*fo = fe->object;
bh_assert(*fo != NULL && "Attempted to detach nonexistent descriptor");
Expand Down
Loading