Skip to content

ci(style): add typos-cli to CI flow#2468

Merged
alexcrichton merged 5 commits intobytecodealliance:mainfrom
mkatychev:ci/typos-cli
Mar 31, 2026
Merged

ci(style): add typos-cli to CI flow#2468
alexcrichton merged 5 commits intobytecodealliance:mainfrom
mkatychev:ci/typos-cli

Conversation

@mkatychev
Copy link
Copy Markdown
Member

Follow up to #2467

@mkatychev mkatychev requested a review from a team as a code owner March 25, 2026 15:35
@mkatychev mkatychev requested review from dicej and pchickey and removed request for a team March 25, 2026 15:35
@pchickey pchickey enabled auto-merge March 25, 2026 19:41
auto-merge was automatically disabled March 30, 2026 12:24

Pull request was closed

@alexcrichton alexcrichton reopened this Mar 30, 2026
@alexcrichton
Copy link
Copy Markdown
Member

This is failing here to start, notably due to:

The action crate-ci/typos@v1.44.0 is not allowed in bytecodealliance/wasm-tools because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: bytecodealliance/, cargo-bins/cargo-binstall@, rust-lang/*.

I'm a bit wary to use a third-party action here myself. Is there a more official location to put this? Or is it small enough that it can be hardcoded here without much work?

@mkatychev
Copy link
Copy Markdown
Member Author

mkatychev commented Mar 30, 2026

This is failing here to start, notably due to:

The action crate-ci/typos@v1.44.0 is not allowed in bytecodealliance/wasm-tools because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: bytecodealliance/, cargo-bins/cargo-binstall@, rust-lang/*.

I'm a bit wary to use a third-party action here myself. Is there a more official location to put this? Or is it small enough that it can be hardcoded here without much work?

I can just hard code it, thanks for the callout.

EDIT: @alexcrichton added a minimal version of it. Glad cargo-binstall is allowed, that made the setup easy to handle.

@mkatychev mkatychev requested a review from alexcrichton March 30, 2026 15:41
@alexcrichton alexcrichton added this pull request to the merge queue Mar 31, 2026
Merged via the queue into bytecodealliance:main with commit d0f7d98 Mar 31, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants