wit-component, wit-parser: preserve doc comments through embed path#2532
wit-component, wit-parser: preserve doc comments through embed path#2532Mees-Molenaar wants to merge 2 commits into
Conversation
|
Thanks! Given the test failures I think it might make sense to ignore errors when decoding this section rather than propagating them up? That looks to be masking other errors and/or causing minor issues. |
|
Thanks for quick review, I agree with your comment. I only see that an offset is now not matching because of an offset. Is that something I need to commit, or do I need to change the implementation so that the offset keeps the same? |
|
Oh offsets changing is fine, that's because there's more stuff in the wasm module now the docs). You can fix that by running the test suite with |
e3a8083 to
db517c1
Compare
|
Added a comment specifying that it is best effort and only drops the documentation when it fails and commited both offset changes. |
For our use case, we want to store some metadata in comments in the wit file. According to the documentation, this should be available. However, we encountered that the embedding path (which is used by wit-bindgen) did not include the comments. This PR fixes that.