Skip to content

Converge to unicode-ident and remove unicode-xid dependency#2535

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
Marcondiro:main
May 31, 2026
Merged

Converge to unicode-ident and remove unicode-xid dependency#2535
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
Marcondiro:main

Conversation

@Marcondiro
Copy link
Copy Markdown
Contributor

@Marcondiro Marcondiro commented May 30, 2026

Hello,

unicode-xid and unicode-ident do the exact same thing and they are both in the dependency tree.
unicode-xid is imported directly while unicode-ident is brought in by serde.

Converge over the more performant unicode-ident.
Ideally this will slightly reduce binary size and slightly reduce compile time.

This PR does not introduce any functional change.

Thanks!

@Marcondiro Marcondiro requested a review from a team as a code owner May 30, 2026 21:15
@Marcondiro Marcondiro requested review from pchickey and removed request for a team May 30, 2026 21:15
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue May 30, 2026
Merged via the queue into bytecodealliance:main with commit 74145d2 May 31, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants