Introduce helper methods for loading from VMContext#13627
Open
fitzgen wants to merge 1 commit into
Open
Conversation
These helpers always use the correct flags and region. Eventually there will be helper methods for all our other `VM*` types as well. Ideally we would mechanically generate all this stuff, and the `VM*` type definitions, and the offset calculation from the same single source of truth via fancy macros or whatever. Haven't fully thought through that yet, but one day. In the meantime, this prevents accidental bugs due to using incorrect flags and regions.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These helpers always use the correct flags and region.
Eventually there will be helper methods for all our other
VM*types as well.Ideally we would mechanically generate all this stuff, and the
VM*type definitions, and the offset calculation from the same single source of truth via fancy macros or whatever. Haven't fully thought through that yet, but one day. In the meantime, this prevents accidental bugs due to using incorrect flags and regions.