Skip to content

Skip rector visibility rule on PolicyCommand (fix cs-stan) #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 3 commits into from
May 12, 2026
Merged

Skip rector visibility rule on PolicyCommand (fix cs-stan) #333

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26c42c5
Align PolicyCommand::buildOptionParser visibility with parent
dereuromark May 12, 2026
8497993
Bump cakephp/bake minimum to ^3.6.4
dereuromark May 12, 2026
fc2226d
Switch approach: skip rector rule on PolicyCommand instead of narrowi…
dereuromark May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector;
use Rector\CodingStyle\Rector\Assign\SplitDoubleAssignRector;
use Rector\CodingStyle\Rector\Catch_\CatchExceptionNameMatchingTypeRector;
use Rector\CodingStyle\Rector\ClassMethod\MakeInheritedMethodVisibilitySameAsParentRector;
use Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector;
use Rector\Config\RectorConfig;
use Rector\DeadCode\Rector\ClassMethod\RemoveUselessReturnTagRector;
Expand Down Expand Up @@ -52,4 +53,13 @@
NewlineAfterStatementRector::class,
ExplicitBoolCompareRector::class,
TypedPropertyFromCreateMockAssignRector::class,

// Parent SimpleBakeCommand::buildOptionParser() switched from public
// to protected in cakephp/bake 3.6.4. Narrowing this override would
// break installs on bake 3.2 - 3.6.3 since PHP forbids reducing a
// parent's visibility. Keeping the override public is forward- and
// backward-compatible (widening is always allowed).
MakeInheritedMethodVisibilitySameAsParentRector::class => [
__DIR__ . '/src/Command/PolicyCommand.php',
],
]);
Loading