Merged
Conversation
LordSimal
commented
Mar 29, 2026
LordSimal
commented
Mar 29, 2026
LordSimal
force-pushed
the
3.x-rector
branch
2 times, most recently
from
019811f to
2074e96
Compare
…mon for AST based logic
dereuromark
reviewed
Mar 29, 2026
| public function getView(): View | ||
| { | ||
| if ($this->view) { | ||
| if ($this->view instanceof BakeView) { |
Member
There was a problem hiding this comment.
I wonder why rector wouldnt just do the faster !== null here.
Since it is technically clear that it can only be that object or null.
Member
There was a problem hiding this comment.
I also would find the current way if ($this->view) "clean", since we always shortcut the bool way with if checks if its clear about the scope (no ambiguity).
Contributor
Author
There was a problem hiding this comment.
Applied rules:
* FlipTypeControlToUseExclusiveTypeRector
* NullableCompareToNullRector
dereuromark
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.