Improved docs for fetchModel()
#7799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
reviewed
Jan 18, 2024
en/controllers.rst
Outdated
| ) | ||
| ->all(); | ||
|
|
||
| .. php:method:: fetchModel(string $alias, array $config = []) |
Member
There was a problem hiding this comment.
This doesn't seem to be the signature used in the examples.
othercorey
reviewed
Jan 18, 2024
| .. php:method:: fetchModel(string $alias, array $config = []) | ||
| The ``fetchModel()`` method is useful to load non ORM models or ORM tables that | ||
| are not the controller's default:: |
Member
There was a problem hiding this comment.
or ORM tables that are not the controller's default
This is the same definition as fetchTable() which is confusing. We should describe fetchModel() for just one use case.
Member
Author
There was a problem hiding this comment.
Well "non ORM models" is the different bit here. This method can fetch any type of model including tables, which is what you get if you don't specify the 2nd argument.
ADmad
commented
Jan 18, 2024
| .. php:method:: fetchModel(string $alias, array $config = []) | ||
| The ``fetchModel()`` method is useful to load non ORM models or ORM tables that | ||
| are not the controller's default:: |
Member
Author
There was a problem hiding this comment.
Well "non ORM models" is the different bit here. This method can fetch any type of model including tables, which is what you get if you don't specify the 2nd argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.