Fix phinx backend using incorrect RollbackCommand class #991
+59
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the phinx backend with Bake installed, discoverPlugin() was finding both builtin and phinx commands. Since both RollbackCommand and MigrationsRollbackCommand have the same defaultName(), the builtin command was overwriting the phinx one due to alphabetical ordering. This fix explicitly registers only the phinx-specific commands instead of using discoverPlugin(), matching the approach used for builtin backend. Fixes #990
jamisonbryant
approved these changes
Jan 8, 2026
Contributor
|
Stan failure is unrelated. GitHub Actions fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RollbackCommandinstead ofMigrationsRollbackCommandRoot Cause
When using
Migrations.backend = 'phinx'with Bake installed,discoverPlugin()scanned the entireCommand/directory and found both:RollbackCommand(builtin) withdefaultName() => 'migrations rollback'MigrationsRollbackCommand(phinx) also returning'migrations rollback'Due to alphabetical ordering during discovery,
RollbackCommand(R > M) was loaded afterMigrationsRollbackCommand, overwriting it.Fix
Replace
discoverPlugin()with explicit command registration for the phinx backend, matching the approach already used for the builtin backend. This ensures only the correct phinx-specific commands are registered.Fixes #990