fix: shorten Exchange calendar app display names to avoid being truncated in onboarding v3 flow#28075
Open
romitg2 wants to merge 2 commits intocalcom:mainfrom
Open
fix: shorten Exchange calendar app display names to avoid being truncated in onboarding v3 flow#28075romitg2 wants to merge 2 commits intocalcom:mainfrom
romitg2 wants to merge 2 commits intocalcom:mainfrom
Conversation
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/app-store/exchange2013calendar/_metadata.ts">
<violation number="1" location="packages/app-store/exchange2013calendar/_metadata.ts:4">
P2: User-facing app display strings should go through i18n (t()) and a translation key instead of hardcoded literals. Add a locale key for the app name and use t(...) here to avoid unlocalized text.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
Issue: in onboarding v3 flow for exchange 2013, and 2016 both only
Microsoft calendar ...is visible, unable to see which one '13, and which one is '16.after:
How should this be tested?
Checklist
Summary by cubic
Shortened display names for the Exchange 2013 and Exchange 2016 calendar apps to prevent truncation in the onboarding v3 flow. Updated metadata name and title to "Exchange 2013" and "Exchange 2016".
Written for commit d10fe7e. Summary will update on new commits.