fix: harden iOS replay runner prewarm#705
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xcodebuild test-without-buildingrunner processes left by standalone prepare.xcodebuildrunner processes before launching a new local runner session, so CI remains reliable even whenprepare ios-runnerwas skipped.test/artifactspaths.Validation
pnpm exec vitest run src/platforms/ios/__tests__/runner-session.test.ts src/daemon/handlers/__tests__/session.test.ts src/platforms/ios/__tests__/runner-command-retry.test.tspnpm check:quickpnpm buildpnpm build:xcuitestnode --experimental-strip-types src/bin.ts prepare ios-runner --platform ios --timeout 300000 --jsonnode --experimental-strip-types src/bin.ts test test/integration/replays/ios/simulator/01-settings.ad --retries 2 --artifacts-dir test/artifacts/replays-ios-simulator-smoke-local-stale-kill --report-junit test/artifacts/replays-ios-simulator-smoke-local-stale-kill.junit.xmlpassed first attempt in 13.9s; runner log showed the stale prepared runner ended withBUILD INTERRUPTED, not XCTestTEST EXECUTE FAILED.pnpm clean:daemon, rannode --experimental-strip-types src/bin.ts test test/integration/replays/ios/simulator/01-settings.ad --retries 2 --artifacts-dir test/artifacts/replays-ios-simulator-smoke-local-no-prework --report-junit test/artifacts/replays-ios-simulator-smoke-local-no-prework.junit.xml; passed first attempt in 16.6s, withopendoing runner prewarm and subsequent runner-backed actions completing quickly.pnpm check:unitwas rerun outside the sandbox and failed in unrelated Android.aabtests; rerunning that file directly passed:pnpm exec vitest run src/platforms/android/__tests__/index.test.ts