Fix issue with long asset names generated from pnpm paths#752
Open
spion wants to merge 1 commit intocallstack:masterfrom
Open
Fix issue with long asset names generated from pnpm paths#752spion wants to merge 1 commit intocallstack:masterfrom
spion wants to merge 1 commit intocallstack:masterfrom
Conversation
Contributor
|
Thanks for the PR @spion |
Author
|
I think metro is completely incapable at working with pnpm due to its extensive usage of symlinks, so I'm not sure how possible it is to reproduce this there. What about hashing the full path but still using the basename? I'd imagine a lot of people will appreciate having at least some indication of what the file is about 😀 P.S. Any suggestions about which hash to use? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #748
Test plan
Example output when compiling react-navigation in a pnpm project:
Might still be an issue if multiple processes or worker threads are running an asset loader module in parallel. Let me know if you'd like a different approach