Acknowledge: expo transitive deps config filtering is intentionally non-variant-specific#242
Closed
Copilot wants to merge 1 commit intorefactor/expo-publishingfrom
Closed
Acknowledge: expo transitive deps config filtering is intentionally non-variant-specific#242Copilot wants to merge 1 commit intorefactor/expo-publishingfrom
Copilot wants to merge 1 commit intorefactor/expo-publishingfrom
Conversation
Copilot
AI
changed the title
[WIP] Work in progress to address expo dependency feedback
Acknowledge: expo transitive deps config filtering is intentionally non-variant-specific
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #238 regarding whether the change from
configurations.matching { it.name.contains(...) }to directly accessing"implementation"and"api"configurations was intentional.Decision
The narrower config lookup (dropping variant-specific names like
debugImplementation,releaseApi, etc.) is intentional — local expo packages (e.g.,expo-constants) do not define variant-specific configurations, so there is nothing to lose by not matching them.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.