Make libimobiledevice optional when native crash detection is off#94
Merged
V3RON merged 4 commits intocallstackincubator:mainfrom Apr 2, 2026
Merged
Conversation
|
@hannojg is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
mrousavy
reviewed
Apr 2, 2026
| const harnessConfigWithoutNativeCrashDetection = { | ||
| metroPort: DEFAULT_METRO_PORT, | ||
| detectNativeCrashes: false, | ||
| } as HarnessConfig; |
There was a problem hiding this comment.
Suggested change
| } as HarnessConfig; | |
| } satisfies HarnessConfig; |
…device-optional # Conflicts: # packages/platform-ios/src/__tests__/instance.test.ts
mrousavy
reviewed
Apr 2, 2026
|
|
||
| const harnessConfig = { | ||
| metroPort: DEFAULT_METRO_PORT, | ||
| } as HarnessConfig; |
There was a problem hiding this comment.
probably better to do satisfies here too but not relevant for this PR now since it's already being set differently in the original code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
AWS Device Farm iOS hosts rely on devicectl but do not ship libimobiledevice. Physical-device runs can still work there as long as Harness is not trying to start the native crash monitor.