Skip to content

fix: activity name being ignored when starting live activity #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rshallam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: activity name being ignored when starting live activity #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ios/src/VoltraModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export type StartVoltraOptions = {
* The ID/name of the Live Activity.
* Allows you to rebind to the same activity on app restart.
*/
activityId?: string
activityName?: string
/**
* Unix timestamp in milliseconds
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/ios/src/live-activity/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ export const startLiveActivity = async (
const targetId = await VoltraModule.startLiveActivity(payload, {
target: 'liveActivity',
deepLinkUrl: options?.deepLinkUrl,
activityId: options?.activityName,
activityName: options?.activityName,
channelId: options?.channelId,
...normalizedSharedOptions,
})
Expand Down
2 changes: 1 addition & 1 deletion packages/voltra/src/VoltraModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export type StartVoltraOptions = {
* The ID/name of the Live Activity.
* Allows you to rebind to the same activity on app restart.
*/
activityId?: string
activityName?: string
/**
* Unix timestamp in milliseconds
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/voltra/src/live-activity/__tests__/options.node.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ describe('Live Activity Options', () => {

expect(VoltraModule.startLiveActivity).toHaveBeenCalledWith(
expect.anything(),
expect.objectContaining({ activityId: 'my-activity' })
expect.objectContaining({ activityName: 'my-activity' })
)
})
})
2 changes: 1 addition & 1 deletion packages/voltra/src/live-activity/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ export const startLiveActivity = async (
const targetId = await VoltraModule.startLiveActivity(payload, {
target: 'liveActivity',
deepLinkUrl: options?.deepLinkUrl,
activityId: options?.activityName,
activityName: options?.activityName,
channelId: options?.channelId,
...normalizedSharedOptions,
})
Expand Down