fix: remove redundant # prefix from tag display#6
Open
victoraraujo105 wants to merge 1 commit intocallumalpass:mainfrom
Open
fix: remove redundant # prefix from tag display#6victoraraujo105 wants to merge 1 commit intocallumalpass:mainfrom
victoraraujo105 wants to merge 1 commit intocallumalpass:mainfrom
Conversation
The TaskNotes HTTP API returns tags with # prefix (from Obsidian's metadata cache). The CLI was unconditionally prepending another #, resulting in ##task display. Just display the API value as-is.
5e460f4 to
01a1290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tags display as
##taskinstead of#taskbecause the CLI prepends#to tags that already have#from the API.Root cause
The TaskNotes HTTP API returns tags from Obsidian's metadata cache, which always prepends
#to frontmatter tag values (e.g.tags: [task]in YAML becomes["#task"]in the cache/API response).lib/utils.jsunconditionally prepends another#for display:Fix
Remove the redundant
#prefix. The API value already includes it:Reproduction
After fix