Separate UI and Backend Error Keys for Localization#459
Open
deepikaSingh2711 wants to merge 8 commits intodevelopfrom
Open
Separate UI and Backend Error Keys for Localization#459deepikaSingh2711 wants to merge 8 commits intodevelopfrom
deepikaSingh2711 wants to merge 8 commits intodevelopfrom
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/integration/com/sap/cds/sdm/IntegrationTest_MultipleFacet.java
Fixed
Show fixed
Hide fixed
deepikaSingh2711
changed the title
yashmeet29
reviewed
Mar 31, 2026
pom.xml
Outdated
|
|
||
| <properties> | ||
| <revision>1.8.1-SNAPSHOT</revision> | ||
| <revision>1.0.0-RC1</revision> |
Collaborator
There was a problem hiding this comment.
Please revert this back
yashmeet29
reviewed
Mar 31, 2026
README.md
Outdated
| SDM.userNotAuthorisedError=Sie verfügen nicht über die erforderlichen Berechtigungen zum Hochladen von Anhängen | ||
| SDM.mimetypeInvalidError=Der Dateityp ist nicht zulässig | ||
| SDM.maxCountErrorMessage=Maximale Anzahl von Anhängen erreicht | ||
| # messages_de.properties |
Collaborator
There was a problem hiding this comment.
Please revert this as before
- Example
messages_de.propertiesfor German language:
Collaborator
Author
There was a problem hiding this comment.
I have changed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Separates error keys into SDMUIErrrorKeys (UI messages - need translation) and SDMErrrorKeys (backend - no translation needed).
Also adds couldNotUploadDocument and couldNotDeleteDocument keys to replace variable-based genericError
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested
Single tenant Integration test
https://github.com/cap-java/sdm/actions/runs/23642925702
Multi tenant Integration test
https://github.com/cap-java/sdm/actions/runs/23659995046