Added cloud deyployment support (st) #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermarc
reviewed
Nov 7, 2025
Co-authored-by: Marc Becker <marc.becker@sap.com>
Co-authored-by: Marc Becker <marc.becker@sap.com>
Co-authored-by: Marc Becker <marc.becker@sap.com>
BraunMatthias
force-pushed
the
prepare-cloud-deployment
branch
from
6b898cf to
9d30133
Compare
beckermarc
reviewed
Nov 17, 2025
Comment on lines
+26
to
+29
| - name: srv-api # required by consumers of CAP services (e.g. approuter) | ||
| properties: | ||
| srv-url: ${default-url} | ||
| srv-cert-url: '${protocol}://${default-host}.cert.${default-domain}' |
Contributor
Author
There was a problem hiding this comment.
It may not be explicitly used in this default configuration, but it is still relevant for advanced configurations. In any case, it was generated by the tools command and therefore follows a pattern that I hesitate to change just for sake of slightly improved simplicity.
Collaborator
There was a problem hiding this comment.
I always prefer to keep configuration as minimalistic as possible and also to always be able to answer why a certain configuration is there. It also makes it easier to understand what's going on.
This one here is useless right now. It might become relevant, once things like approuter, or so are added, but that's not the case now. IMO it should be added by the tools once it is actually needed.
beckermarc
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.