fix: guard pool metrics against NaN/Infinity/undefined values (fixes #6)#225
Open
jiangyj545 wants to merge 1 commit into
Open
fix: guard pool metrics against NaN/Infinity/undefined values (fixes #6)#225jiangyj545 wants to merge 1 commit into
jiangyj545 wants to merge 1 commit into
Conversation
…apofficial#6) - Add > 0 check in feeAPY calculation to prevent division by zero - Add safeMetric() helper for null-safe metric display - Show '-' instead of NaN/Infinity/undefined in all pool metric cells - Use strict equality (> 0 instead of == 0) for % of Pool calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #6 reports that pool performance metrics show incorrect or nonsensical numbers.
Root Cause Analysis
Three categories of bugs in
src/components/pool/Pools.svelte:Division by zero in feeAPY:
setFeeAPYs()divides by_balances[asset]without checking if the value is > 0. When balance is 0, undefined, or not yet loaded → Infinity or NaN displayed as APY %.No null-safety on store values:
$globalUPLs[asset],$bufferBalances[asset],$poolStakes[asset]are rendered directly vianumberWithCommas(). Before stores populate (or for missing assets) these are undefined → displays raw "undefined" or misleading "0".Loose equality in % of Pool: Uses
== 0instead of> 0check, meaning falsy values slip through.Fix
> 0guard insetFeeAPYs()— only calculates APY when balance is positivesafeMetric()helper — returns"-"for undefined/null/NaN/Infinity valuessafeMetric()to all 6 metric cells: Balance, Fee APY, Trader UP/L, Buffer, Your Balance% of Poolfrom== 0to> 0strict checkChanges
src/components/pool/Pools.svelteBuild
✅
npx rollup -cpasses cleanly (only pre-existing warnings)