-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(NumberInput): updated locale format validation arabic japanese #21135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21135 +/- ##
==========================================
- Coverage 92.62% 92.60% -0.02%
==========================================
Files 515 515
Lines 38225 38299 +74
Branches 5861 5866 +5
==========================================
+ Hits 35406 35467 +61
- Misses 2670 2682 +12
- Partials 149 150 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@abpaul1993 Please update the |
|
@kennylam I have updated the PR details based on the feedback. |
Closes #
This PR enhances our number parsing and validation logic to support all major Unicode numeral systems recognized by Intl.NumberFormat in validateNumberSeparators method along with the valid decimal and group seperator.
Previously, only Western digits were handled in the method.
With this update, the number input component now correctly accepts, validates, and normalizes numerals from multiple writing systems—matching real-world locale behavior across international users.
Changelog
New
Changed
Removed
Testing / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide