-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(menu-button): close behavior and ensure menu overlays #21184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(menu-button): close behavior and ensure menu overlays #21184
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21184 +/- ##
==========================================
- Coverage 85.17% 85.08% -0.10%
==========================================
Files 530 530
Lines 40889 41015 +126
Branches 6280 6350 +70
==========================================
+ Hits 34829 34898 +69
- Misses 5900 5955 +55
- Partials 160 162 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maradwan26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #21159
Closes #20349
This PR fixes
cds-menu-button/cds-menuback in line with React so menus close when they should and stay on top of nearby content.Changelog
New
NoneChanged
cds-menulistens for${prefix}-menu-close-root-requestfrom menu items, resets its placement when open flips, and passes the original trigger event through ${prefix}-menu-closed.modal z-indexso the overlay doesn’t hide behind nearby content.Removed
@query(${prefix}-menu)since the menu lives in the light DOM slot.Testing / Reviewing
WC Deploy Preview>Menu ButtonPR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide