register bot commands for existing bot id (bot registration)#3923
register bot commands for existing bot id (bot registration)#3923tintinthong wants to merge 1 commit intomainfrom
Conversation
Host Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2a8c392. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a8c392ee3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export interface CommandInputEvent extends BaseMatrixEvent { | ||
| content: { | ||
| // TODO: confirm whether this should be a serialized card type (e.g., SerializedFile) | ||
| // instead of generic JSON. | ||
| commandInput: Record<string, unknown>; |
There was a problem hiding this comment.
All other Matrix event interfaces include a type field, but CommandInputEvent does not. Because BaseMatrixEvent doesn’t define type, this makes MatrixEvent no longer guarantee a type discriminator and allows CommandInputEvent objects to be constructed without an event type. In practice, any code that emits a command-input event using this interface can omit the APP_BOXEL_COMMAND_INPUT_EVENT_TYPE, causing routing/filtering by event type to drop the command at runtime. Consider adding type: typeof APP_BOXEL_COMMAND_INPUT_EVENT_TYPE to keep the union discriminated and enforce valid events.
Useful? React with 👍 / 👎.
1 participant
No description provided.