Add ImageDef with PngDef, JpgDef, SvgDef, GifDef, and WebpDef#3939
Open
Add ImageDef with PngDef, JpgDef, SvgDef, GifDef, and WebpDef#3939
Conversation
Preview deployments |
Host Test Results 1 files ± 0 1 suites ±0 1h 44m 53s ⏱️ -45s For more details on these errors, see this check. Results for commit 6a5cf8a. ± Comparison against base commit 00abc16. ♻️ This comment has been updated with latest results. |
Introduce ImageDef (extends FileDef) with isolated, embedded, atom, and fitted format components, and PngDef (extends ImageDef) with PNG dimension extraction. The atom format shows a small thumbnail with the file name, embedded renders the image at container width with natural height, and fitted uses a CSS background-image to cover available space. Includes a PNG metadata extractor and acceptance tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The check at line 277 was unreachable since Uint8Array is already handled at line 258 in the if-else chain. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lukemelia
force-pushed
the
cs-9912-implement-pngimagedef
branch
from
e93d5eb to
24cf925
Compare
Tests were using string content for .png files which caused the PNG extractor to fail and fall back to ImageDef. Updated tests to use actual PNG binary data so PngDef extraction succeeds. - Add makeMinimalPng helper to test helpers - Update card-basics-test to use valid PNG bytes - Update card-endpoints-test to use valid PNG bytes and expect PngDef Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…s errors When the server fails a cross-realm query (e.g. remote realm unreachable), it returns error metadata in the relationship. Previously the client treated the empty seed data as authoritative and showed no results. Now the client detects queryErrors in the seed, skips caching the previousQueryString, and triggers a live client-side search as a fallback. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The FileDef render tests were using .png files, but with the new PngDef implementation, PNG files are indexed as PngDef/ImageDef which renders a background image instead of showing the filename as text. Changed to .txt files so the tests properly verify FileDef's text-based rendering. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* add invite user to room command * add missing inviteUserToRoom method in matrixService * add missing input to command * fix lint
… start/end period, not invoice period
Adds .mcp.json with MCP server entries for Linear and Chrome DevTools. To authenticate to Linear, run "/mcp" in Claude Code. This will open a browser-based OAuth flow to connect your Linear account. Once authenticated, Claude Code can interact with Linear issues, projects, and other resources via the MCP protocol. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lukemelia
changed the title
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lukemelia
changed the title
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lukemelia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageDef(extendsFileDef) with four format components: isolated, embedded, atom, and fittedPngDef— PNG dimension extraction viapng-meta-extractorJpgDef— JPEG dimension extraction viajpg-meta-extractor(scans SOF markers)SvgDef— SVG dimension extraction viasvg-meta-extractor(explicit attrs + viewBox fallback)GifDef— GIF dimension extraction viagif-meta-extractor(GIF87a/GIF89a)WebpDef— WebP dimension extraction viawebp-meta-extractor(VP8, VP8L, VP8X).png,.jpg,.jpeg,.svg,.gif, and.webpextensions inFILEDEF_CODE_REF_BY_EXTENSIONTest plan
png-image-defacceptance testsjpg-image-defacceptance testssvg-image-defacceptance tests (including viewBox-only)gif-image-defacceptance testswebp-image-defacceptance tests🤖 Generated with Claude Code