Add last_known_good_deps so error state cards have prerendered CSS#3942
Draft
Add last_known_good_deps so error state cards have prerendered CSS#3942
Conversation
Preview deployments |
The test was timing out because breaking a module alone doesn't automatically trigger re-indexing of dependent instances. Adding a PATCH request to the instance forces it to re-index and encounter the broken module, causing it to enter an error state as expected. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The BoxelIndexTable type now requires the last_known_good_deps field, so test assertions comparing against this type need to include it. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PATCH validates the card against the module, which fails when the module is broken. Using a raw JSON write via POST with application/vnd.card+source bypasses validation and triggers re-indexing, which then encounters the broken module. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Instead of breaking the module and hoping the error propagates to the instance, make the instance reference a non-existent module. This directly causes the instance to fail indexing and is more reliable than relying on module dependency propagation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.