Skip to content

host: Add handling for editor cancellations #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backspace wants to merge 5 commits into
base: main
Choose a base branch
from
Open

host: Add handling for editor cancellations #3948

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39780c4
host: Add handling for editor cancellations
backspace Feb 4, 2026
3c5465f
Merge branch 'main' into host/editor-cancel-task-cs-10129
backspace Feb 4, 2026
971b5c9
Merge remote-tracking branch 'origin/main' into host/editor-cancel-ta…
backspace Feb 5, 2026
8e0a60e
Fix spelling
backspace Feb 5, 2026
4cabe3b
Fix wording and spacing
backspace Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/host/app/components/operator-mode/code-editor.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@ import { service } from '@ember/service';
import Component from '@glimmer/component';
import { cached, tracked } from '@glimmer/tracking';

import { task, restartableTask, timeout, all } from 'ember-concurrency';
import {
task,
restartableTask,
timeout,
all,
didCancel,
} from 'ember-concurrency';

import perform from 'ember-concurrency/helpers/perform';

Expand Down Expand Up @@ -471,6 +477,12 @@ export default class CodeEditor extends Component<Signature> {
saveType,
})
.catch((error) => {
// Task cancellations are expected when the restartable contentChangedTask is
// performed again while still running - this is normal behaviour, not an error
if (didCancel(error)) {
return;
}

if (error?.status === 413 && error?.title) {
this.args.onWriteError?.(error.title);
return;
Expand Down