Refactor Store#search to support FileDef and fix N+1 query issue#3955
Merged
Refactor Store#search to support FileDef and fix N+1 query issue#3955
Conversation
- Make Store#search generic to support both CardDef and FileDef queries
- Add { includeMeta: true } option to return pagination metadata
- Extract shared search logic into private fetchAndHydrateSearchResults
- Add _addResourceFromSearchData to hydrate resources from search response
without making individual network requests (fixes N+1 query problem)
- Simplify SearchResource to delegate to Store#search
- Remove code duplication between SearchResource and Store
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Preview deployments |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the Store#search method to support generic types for both CardDef and FileDef queries, adds an option to include pagination metadata, and fixes an N+1 query issue. The changes consolidate approximately 95 lines of duplicated code between Store and SearchResource.
Changes:
- Made
Store#searchgeneric to support bothCardDefandFileDefqueries with proper type overloads - Added
{ includeMeta: true }option to return pagination metadata alongside instances - Extracted shared search logic into
fetchAndHydrateSearchResultsprivate method and added_addResourceFromSearchDatato hydrate resources directly from search response data, eliminating N+1 queries - Simplified
SearchResourceto delegate toStore#searchinstead of duplicating fetch/hydrate logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/host/app/services/store.ts | Added generic type parameters to search method with overloads for optional metadata, refactored search logic into fetchAndHydrateSearchResults, added _addResourceFromSearchData for efficient resource hydration, and updated imports to support both card and file-meta resources |
| packages/host/app/resources/search.ts | Simplified implementation to delegate to Store#search with includeMeta: true option, removing ~75 lines of duplicated fetch/hydrate logic and unnecessary imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lukemelia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store#searchgeneric to support bothCardDefandFileDefqueries{ includeMeta: true }option to return pagination metadata alongside instancesfetchAndHydrateSearchResultsmethod_addResourceFromSearchDatato hydrate resources directly from search response data without making individual network requests (fixes N+1 query problem)SearchResourceto delegate toStore#searchinstead of duplicating fetch/hydrate logicSearchResourceandStoreTest plan
🤖 Generated with Claude Code