Draft
Conversation
Phase 1 - Infrastructure: - Change baseRealm.url constant to '@cardstack/base/' - Switch network.ts from addURLMapping to addImportMap + registerCardReferencePrefix - Update all mise-tasks and shell scripts --fromUrl flags - Fix baseRealm.inRealm() call sites - Update test helpers to use import map pattern Phase 2 - Bulk replacement: - Replace all https://cardstack.com/base/ references in .ts/.gts/.json/.js files Phase 3 - Edge cases (WIP): - Fix new URL('@cardstack/base/') calls that would throw - Fix catalog.ts baseRealmPath to use string prefix check Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Preview deployments |
Realm Server Test Results 1 files ± 0 1 suites ±0 13m 47s ⏱️ -20s For more details on these failures, see this check. Results for commit 4bb8576. ± Comparison against base commit e549179. This pull request removes 327 tests.♻️ This comment has been updated with latest results. |
- Merge latest main (picks up new files with https://cardstack.com/base/) - All references already converted to @cardstack/base/ by merge - Remove wrong DB migration (permissions use resolved URLs, not prefixes) - Add PATH fix for mise dev task Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Card and module IDs can now be in prefix form (e.g. @cardstack/base/card-api) which is not a valid URL. Replace new URL(id) with cardIdToURL(id) from runtime-common in all host app code that handles card/module identifiers. Also fix RealmResource to resolve prefix-form realm URLs before making HTTP requests (_info, _config, _permissions, _publishability endpoints). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Systematic replacement of new URL(id) with cardIdToURL(id) in host app code that handles module references, code refs, spec IDs, dependency URLs, and card IDs — all of which can now be in @cardstack/base/ prefix form. Files updated: check-correctness, listing-create, listing-install, listing-update-specs, show-card, room, card-schema-editor, edit-field-modal, playground-panel, spec-preview, create-file-modal, module route, operator-mode-state-service, store. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…-cs-10286 # Conflicts: # packages/eslint-plugin-boxel/lib/recommended-rules.js # packages/host/app/commands/listing-create.ts # packages/host/app/services/card-type-service.ts # packages/software-factory/tests/factory-tool-executor.spec.ts
…-cs-10286 # Conflicts: # packages/ai-bot/tsconfig.json # packages/billing/tsconfig.json # packages/bot-runner/tsconfig.json # packages/boxel-ui/addon/tsconfig.json # packages/catalog-realm/SubmissionCardPortal/b535d5fb-8eef-44a6-8114-4bce6929b95a.json # packages/catalog-realm/commands/collect-submission-files.ts # packages/catalog-realm/commands/create-pr-card.ts # packages/catalog-realm/pr-card/pr-card.gts # packages/catalog-realm/tsconfig.json # packages/experiments-realm/tsconfig.json # packages/host/app/commands/bot-requests/create-listing-pr-request.ts # packages/host/app/commands/create-and-open-submission-workflow-card.ts # packages/host/app/commands/listing-create.ts # packages/host/app/commands/listing-install.ts # packages/host/app/commands/listing-remix.ts # packages/host/app/commands/listing-use.ts # packages/host/app/commands/search-and-choose.ts # packages/host/tsconfig.json # packages/matrix/tsconfig.json # packages/postgres/tsconfig.json # packages/realm-server/tsconfig.json # packages/runtime-common/tsconfig.json # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-command-development.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-core-patterns.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-data-management.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-enumerations.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-external-libraries.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-file-def.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-file-editing.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-quick-reference.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-replicate-ai.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-spec-usage.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-template-patterns.md # packages/software-factory/experiment_1/.agents/skills/boxel-development/references/dev-theme-design-system.md # packages/software-factory/experiment_1/.agents/skills/boxel-file-structure/SKILL.md # packages/software-factory/experiment_1/realms/guidance-tasks/KnowledgeArticle/agent-onboarding.json # packages/software-factory/experiment_1/realms/guidance-tasks/Project/demo-project.json # packages/software-factory/experiment_1/realms/guidance-tasks/Ticket/ticket-001.json # packages/software-factory/experiment_1/realms/guidance-tasks/darkfactory-schema.gts # packages/software-factory/experiment_1/realms/guidance-tasks/darkfactory-ui.gts # packages/software-factory/experiment_1/realms/guidance-tasks/index.json # packages/software-factory/prompts/examples/create-card.md # packages/software-factory/prompts/examples/iterate-fix.md # packages/vscode-boxel-tools/tsconfig.json
…-cs-10286 # Conflicts: # packages/host/app/utils/file-def-attributes-extractor.ts # packages/host/tests/helpers/base-realm.ts # packages/runtime-common/resource-types.ts
…-cs-10286 # Conflicts: # packages/software-factory/realm/darkfactory.gts # packages/software-factory/realm/test-results.gts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.