host: Fix some deprecation warnings#5221
Draft
backspace wants to merge 5 commits into
Draft
Conversation
Removes ember-freestyle's deprecated `inject` imports from `@ember/service`, which trigger the importing-inject-from-ember-service deprecation (slated for removal in ember-source 7.0.0). The 0.24.0 import surface is unchanged: the freestyle-guide/section/usage component paths, the freestyle controller, and the css-variable decorator all still resolve. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
…ion fixes These three addons import deprecated symbols that emit warnings under Ember 6 (and are removed in ember-source 7.0.0): `inject` from `@ember/service`, and `ViewUtils`/`_setClassicDecorator` from the `ember` barrel. None have a released fix yet. - ember-elsewhere and ember-set-body-class: point at the upstream fix branches via github: overrides (lockfile pins the exact commits). - ember-animated: patch the published 2.2.0 to import getViewBounds from @ember/-internals/views, setClassicDecorator from @ember/-internals/metal, and service from @ember/service in the animated-* components. Temporary until each upstream fix is released. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ember-keyboard 8.2.1 imported `inject` from `@ember/service` in its on-key modifier, key-responder decorator, and on-key helper, emitting the importing-inject-from-ember-service deprecation. 9.0.4 resolves the service injection without the deprecated import and widens its @ember/test-helpers peer range to cover the v5 used here. The on-key modifier API is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The test-app pinned ember-page-title ^8.0.0, which imports `inject` from `@ember/service` and emits the importing-inject-from-ember-service deprecation in that suite. Match the host's ^9.0.3, which resolves it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These three were bumped with inline version ranges across host and boxel-ui packages. Centralize them in the pnpm catalog so the versions are declared once, matching the convention used by the other ember-* dependencies. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Ember 6 update we have some new deprecation warnings:
ember-freestyle0.24 andember-keyboard9 fixed some of these, but unfortunately other addons that produce these don’t have merged fixes yet:ember-animatedhas an open PRember-elsewhereember-set-body-classalso has a PRWith patches or overrides to use those PR branches, the deprecations are gone: