Cover adjust-flavored bootstrap seed in software-factory tests#5233
Open
jurgenwerk wants to merge 1 commit into
Open
Cover adjust-flavored bootstrap seed in software-factory tests#5233jurgenwerk wants to merge 1 commit into
jurgenwerk wants to merge 1 commit into
Conversation
Add a seed test mirroring the existing greenfield case but with a brief that carries a `sourceCardUrl`, asserting `createSeedIssue` produces the adjust-flavored bootstrap seed: the ADJUST mode header, the source-card reference, and the `boxel realm ingest-card` instruction. Commit the `adjust-mortgage-test.json` brief fixture the test mirrors. This covers the mechanical seed branch of the improve flow; the agent-driven seed-from-source, green-baseline, and improved-card assertions remain out of scope (CS-11406). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds automated coverage for the “adjust existing card” branch of software-factory bootstrap seed generation by introducing a committed brief fixture with sourceCardUrl and a Playwright test that asserts the adjust-specific seed instructions are emitted.
Changes:
- Added an “adjust” brief fixture card (
adjust-mortgage-test.json) that includessourceCardUrlto trigger adjust-flow seed behavior. - Added a Playwright test case asserting
createSeedIssue()produces adjust-flavored seed content (mode header, source-card reference, and ingest-card command) whensourceCardUrlis present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/software-factory/tests/factory-seed.spec.ts | Adds a new test validating adjust-flow bootstrap seed instructions when a brief includes sourceCardUrl. |
| packages/software-factory/realm/Wiki/adjust-mortgage-test.json | Introduces a new Wiki brief fixture that carries sourceCardUrl to flip the factory into adjust mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
habdelra
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Written by Claude on Matic's behalf.)
CS-11406: prove the improve (adjust-existing-card) flow with a committed fixture + a test, building on the flow shipped in CS-11424 (which was only verified manually).
What this adds
realm/Wiki/adjust-mortgage-test.json) carrying asourceCardUrl, the signal that flips the factory into the adjust flow.factory-seed.spec.ts(mirroring the existing greenfield seed test) asserting that, when the brief carries asourceCardUrl,createSeedIssueemits the adjust-flavored bootstrap seed: theMode: ADJUST EXISTING CARDheader, theSource card to adjust:reference, and theboxel realm ingest-card "<url>"instruction — i.e. the mechanical adjust branch infactory-seed.tsthat runs before the agent.Runs under the existing hermetic Playwright harness (isolated realm,
bootstrap-targetfixture) — no agent, no subprocess.Testing
Local global-setup (
cache:prepare) is slow/flaky to spin up the hermetic stack; leaving CI to validate in a clean environment.🤖 Generated with Claude Code