Instantiate all boundary types AND api changes for sendt#85
Closed
devanshj wants to merge 3 commits intocassiozen:mainfrom
Closed
Instantiate all boundary types AND api changes for sendt#85devanshj wants to merge 3 commits intocassiozen:mainfrom
sendt#85devanshj wants to merge 3 commits intocassiozen:mainfrom
Conversation
machine = { ...machineInstant, send }
Machine.State -> Machine
machineState -> machineInstant
machineState.value -> machineInstant.state
Machine.StateValue -> Machine.State
devanshj
changed the title
sendtsendt
Contributor
Author
|
Closing in favor of #86, I guess that has a cleaner tree (at least for a git noob like me :P) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #72 but some tests fixed. And hence also has #76 which was reverted. I guess I'll also have to rebase to new main, will do that
Also is the CI not running
yarn test?