Skip to content

feat: add semantic _defs and link from schemas#291

Open
xibz wants to merge 1 commit intocdevents:mainfrom
xibz:main
Open

feat: add semantic _defs and link from schemas#291
xibz wants to merge 1 commit intocdevents:mainfrom
xibz:main

Conversation

@xibz
Copy link
Contributor

@xibz xibz commented Feb 10, 2026

Introduce initial opinionated semantic definitions under _defs and reference them from event schemas.

Definitions are versioned alongside schemas, allowing terminology to evolve explicitly if scope or meaning changes in future CDEvents revisions.

Introduce initial opinionated semantic definitions under `_defs` and
reference them from event schemas.

Definitions are versioned alongside schemas, allowing terminology to
evolve explicitly if scope or meaning changes in future CDEvents
revisions.

Signed-off-by: xibz <bjp@apple.com>
@xibz xibz requested a review from a team as a code owner February 10, 2026 04:01
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it looks good!

@afrittoli
Copy link
Member

The linter failure has to be addressed:

 2026-02-17 17:56:13 [INFO]   Linting JSON items...
  Error: -17 17:56:14 [ERROR]   Found errors when linting JSON. Exit code: 1.
  2026-02-17 17:56:14 [INFO]   Command output for JSON:
  ------
  /github/workspace/schemas/_defs/artifact.json
    11:3  error  Property name `out_of_scope` must match one of the following formats: camelCase  jsonc/key-name-casing
  /github/workspace/schemas/_defs/pipelinerun.json
    14:3  error  Property name `out_of_scope` must match one of the following formats: camelCase  jsonc/key-name-casing
  /github/workspace/schemas/_defs/started.json
    14:3  error  Property name `out_of_scope` must match one of the following formats: camelCase  jsonc/key-name-casing
  /github/workspace/schemas/pipelinerunstarted.json
    4:3  error  Property name `x-cdevents-semantics` must match one of the following formats: camelCase  jsonc/key-name-casing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants